feat: enforce admin access control across multiple pages

Author: nicosammito

src/app/layout.tsx

@@ -28,17 +28,6 @@ const inter = Inter({
     display: "swap",
 })
 
-/**
- * Override console error and warn in development to log to console.log
- */
-if (process.env.NODE_ENV === "development" && typeof window !== "undefined") {
-    console.error = (...args: unknown[]) => {
-        console.log(args)
-    }
-
-    console.error.bind(console);
-    console.warn.bind(console);
-}
 
 /**
  * Mapping of error codes to their descriptions

src/packages/ce/src/dashboard/application/ApplicationSettingsPage.tsx

@@ -29,7 +29,7 @@ export const ApplicationSettingsPage: React.FC = () => {
     const currentUser = React.useMemo(() => userService.getById(currentSession?.user?.id), [userStore, currentSession])
 
     if (currentUser && !currentUser.admin) {
-        return notFound()
+        notFound()
     }
 
     return <>

src/packages/ce/src/dashboard/application/RuntimeCreatePage.tsx

@@ -10,7 +10,8 @@ import {
     TextInput,
     toast,
     useForm,
-    useService, useStore,
+    useService,
+    useStore,
     useUserSession
 } from "@code0-tech/pictor";
 import Link from "next/link";
@@ -25,12 +26,13 @@ export const RuntimeCreatePage: React.FC = () => {
     const [token, setToken] = React.useState<string | null | undefined>(undefined)
     const router = useRouter()
     const currentSession = useUserSession()
+
     const userStore = useStore(UserService)
     const userService = useService(UserService)
     const currentUser = React.useMemo(() => userService.getById(currentSession?.user?.id), [userStore, currentSession])
 
     if (currentUser && !currentUser.admin) {
-        return notFound()
+        notFound()
     }
 
     const [inputs, validate] = useForm({
@@ -56,7 +58,7 @@ export const RuntimeCreatePage: React.FC = () => {
                 }).then(payload => {
                     if ((payload?.errors?.length ?? 0) <= 0) {
                         if (payload?.runtime?.token) {
-                            setToken(payload.runtime.token)
+                            if (!token) setToken(payload.runtime.token)
                         } else {
                             toast({
                                 title: "The runtime was created but no token was provided.",

src/packages/ce/src/dashboard/application/RuntimeSettingPage.tsx

@@ -38,11 +38,11 @@ export const RuntimeSettingPage: React.FC = () => {
     const runtime = React.useMemo(() => runtimeService.getById(`gid://sagittarius/Runtime/${params.runtimeId as any}`), [runtimeStore, params])
 
     if (currentUser && !currentUser.admin) {
-        return notFound()
+        notFound()
     }
 
     if (runtime?.userAbilities && (!runtime?.userAbilities?.updateRuntime || !runtime.userAbilities.deleteRuntime || !runtime.userAbilities.rotateRuntimeToken)) {
-        return notFound()
+        notFound()
     }
 
     const initialValues = React.useMemo(() => ({

src/packages/ce/src/dashboard/application/RuntimesPage.tsx

@@ -26,7 +26,7 @@ export const RuntimesPage: React.FC = () => {
     const currentUser = React.useMemo(() => userService.getById(currentSession?.user?.id), [userStore, currentSession])
 
     if (currentUser && !currentUser.admin) {
-        return notFound()
+        notFound()
     }
 
     return <>

src/packages/ce/src/dashboard/application/UsersPage.tsx

@@ -20,7 +20,7 @@ export const UsersPage: React.FC = () => {
     const currentUser = React.useMemo(() => userService.getById(currentSession?.user?.id), [userStore, currentSession])
 
     if (currentUser && !currentUser.admin) {
-        return notFound()
+        notFound()
     }
 
     return <>