Skip to content

Commit a75076d

Browse files
committed
feat: update data type identifiers from ARRAY to LIST and include identifier in resolved types
1 parent 759dfdb commit a75076d

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/components/d-flow-data-type/DFlowDataType.service.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export abstract class DFlowDataTypeReactiveService extends ReactiveArrayService<
3838

3939
if (value.__typename == "LiteralValue") {
4040
//hardcode primitive types (NUMBER, BOOLEAN, TEXT)
41-
if (Array.isArray(value.value) && Array.from(value.value).length > 0) return this.getDataType({dataType: {identifier: "ARRAY"}})
41+
if (Array.isArray(value.value) && Array.from(value.value).length > 0) return this.getDataType({dataType: {identifier: "LIST"}})
4242
if (typeof value.value === "string") return this.getDataType({dataType: {identifier: "TEXT"}}, dependencies)
4343
if (typeof value.value === "number") return this.getDataType({dataType: {identifier: "NUMBER"}}, dependencies)
4444
if (typeof value.value === "boolean") return this.getDataType({dataType: {identifier: "BOOLEAN"}}, dependencies)
@@ -62,7 +62,7 @@ export abstract class DFlowDataTypeReactiveService extends ReactiveArrayService<
6262
if (value.__typename === "ReferenceValue") return value.dataTypeIdentifier
6363

6464
const dataType = this.getDataTypeFromValue(value, flow, dependencies)
65-
if ((dataType?.genericKeys?.length ?? 0) <= 0 || !dataType?.genericKeys) return {dataType: {id: dataType?.id}}
65+
if ((dataType?.genericKeys?.length ?? 0) <= 0 || !dataType?.genericKeys) return {dataType: {id: dataType?.id, identifier: dataType?.identifier}}
6666

6767
//TODO: missing generic combinations
6868
const genericMapper: GenericMapper[] = dataType.genericKeys.map(genericKey => {
@@ -125,12 +125,13 @@ export abstract class DFlowDataTypeReactiveService extends ReactiveArrayService<
125125

126126
const resolvedType: DataTypeIdentifier = genericMapper.length > 0 ? {
127127
genericType: {
128-
dataType: {id: dataType.id as Maybe<Scalars['DataTypeID']['output']>},
128+
dataType: {id: dataType.id as Maybe<Scalars['DataTypeID']['output']>, identifier: dataType.identifier},
129129
genericMappers: genericMapper
130130
}
131131
} : {
132132
dataType: {
133-
id: dataType.id as Maybe<Scalars['DataTypeID']['output']>
133+
id: dataType.id as Maybe<Scalars['DataTypeID']['output']>,
134+
identifier: dataType.identifier
134135
}
135136
}
136137

0 commit comments

Comments
 (0)