feat: add null checks in getById methods across multiple services

Author: nicosammito

src/components/d-member/DNamespaceMember.service.ts

@@ -19,7 +19,7 @@ export type DMemberDependencies = {
 export abstract class DNamespaceMemberReactiveService extends ReactiveArrayService<DNamespaceMemberView, DMemberDependencies> {
 
     getById(id: NamespaceMember['id'], dependencies?: DMemberDependencies): DNamespaceMemberView | undefined {
-        return this.values(dependencies).find(member => member.id === id);
+        return this.values(dependencies).find(member => member && member.id === id);
     }
 
     getByNamespaceIdAndUserId(namespaceId: Namespace['id'], userId: User['id']): DNamespaceMemberView | undefined {

src/components/d-namespace/DNamespace.service.ts

@@ -5,7 +5,7 @@ import {ReactiveArrayService} from "../../utils";
 export abstract class DNamespaceReactiveService extends ReactiveArrayService<DNamespaceView> {
 
     getById(id: Namespace['id']): DNamespaceView | undefined {
-        return this.values().find(namespace => namespace.id === id);
+        return this.values().find(namespace => namespace && namespace.id === id);
     }
 
 }

src/components/d-organization/DOrganization.service.ts

@@ -11,7 +11,7 @@ import {
 export abstract class DOrganizationReactiveService extends ReactiveArrayService<DOrganizationView> {
 
     getById(id: Organization["id"]): DOrganizationView | undefined {
-        return this.values().find(organization => organization.id === id)
+        return this.values().find(organization => organization && organization.id === id)
     }
 
     abstract organizationCreate(payload: OrganizationsCreateInput): Promise<OrganizationsCreatePayload | undefined>

src/components/d-project/DNamespaceProject.service.ts

@@ -15,7 +15,7 @@ export type DProjectDependencies = {
 export abstract class DNamespaceProjectReactiveService extends ReactiveArrayService<DNamespaceProjectView, DProjectDependencies> {
 
     getById(id: NamespaceProject['id'], dependencies?: DProjectDependencies): DNamespaceProjectView | undefined {
-        return this.values(dependencies).find(project => project.id === id)
+        return this.values(dependencies).find(project => project && project.id === id)
     }
 
     abstract projectAssignRuntimes(payload: NamespacesProjectsAssignRuntimesInput): Promise<NamespacesProjectsAssignRuntimesPayload | undefined>

src/components/d-role/DNamespaceRole.service.ts

@@ -20,7 +20,7 @@ export type DRoleDependencies = {
 export abstract class DNamespaceRoleReactiveService extends ReactiveArrayService<DNamespaceRoleView, DRoleDependencies> {
 
     getById(id: NamespaceRole['id'], dependencies?: DRoleDependencies): DNamespaceRoleView | undefined {
-        return this.values(dependencies).find(role => role.id === id);
+        return this.values(dependencies).find(role => role && role.id === id);
     }
 
     abstract roleAssignAbilities(payload: NamespacesRolesAssignAbilitiesInput): Promise<NamespacesRolesAssignAbilitiesPayload | undefined>

src/components/d-runtime/DRuntime.service.ts

@@ -18,7 +18,7 @@ export type DRuntimeDependencies = {
 export abstract class DRuntimeReactiveService extends ReactiveArrayService<DRuntimeView, DRuntimeDependencies> {
 
     getById(id: Runtime['id']): DRuntimeView | undefined {
-        return this.values().find(runtime => runtime.id === id);
+        return this.values().find(runtime => runtime && runtime.id === id);
     }
 
     abstract runtimeCreate(payload: RuntimesCreateInput): Promise<RuntimesCreatePayload | undefined>

src/components/d-user/DUser.service.ts

@@ -1,4 +1,4 @@
-import {ReactiveArrayService} from "../../utils/reactiveArrayService";
+import {ReactiveArrayService} from "../../utils";
 import {
     User,
     UsersEmailVerificationInput,
@@ -36,11 +36,11 @@ export abstract class DUserReactiveService extends ReactiveArrayService<DUserVie
     //no id's need to be injected here because the root query has a users field
 
     getById(id: User['id']): DUserView | undefined {
-        return this.values().find(user => user.id === id);
+        return this.values().find(user => user && user.id === id);
     }
 
     getByUsername(username: User['username']): DUserView | undefined {
-        return this.values().find(user => user.username === username);
+        return this.values().find(user => user && user.username === username);
     }
 
     abstract usersEmailVerification(payload: UsersEmailVerificationInput): Promise<UsersEmailVerificationPayload | undefined>;