29 Jan 2024

Some code clean up:
1) NFC & QR login lib - Check valid user before creating hash.
2) Combined user login and item batch to use the same QR generation page.
3) Removed user login QR code page.

Author: code-boxx

README.md

@@ -5,7 +5,7 @@ Storage Boxx is an open-source PHP Inventory Management System. With a built-in
 ## :white_check_mark: "OUT OF THE BOX" FEATURES
 1) Generate item QR code, built-in QR code scanner.
 2) Create item NFC tags, built-in NFC scanner.
-3) Passwordless login - NFC and Web Authentication (Biometric, PIN, Face Recognition)
+3) Passwordless login - QR, NFC, Web Authentication (Biometric, PIN, Face Recognition).
 4) Stock level monitoring, push notifications on low stock.
 5) Batch and expiration tracking.
 6) Installable progressive web app.
@@ -32,7 +32,7 @@ Storage Boxx is an open-source PHP Inventory Management System. With a built-in
 <br><br>
 
 ## :floppy_disk: INSTALLATION
-1) Copy & unzip into your `http` folder.
+1) Manually download or git clone into your `http` folder.
 2) Access `http://your-site.com/` in your browser and walk through the installer.
 3) If you want, add the [optional AI Assistant](https://github.com/code-boxx/Storage-Boxx-AI) after the installation.
 <br><br>

assets/PAGE-batch.js

@@ -81,7 +81,11 @@ var batch = {
   })),
 
   // (H) GENERATE QR CODE
-  qr : (sku, name) => window.open(cbhost.base + "qrcode/?sku="+sku+"&name="+name),
+  qr : (sku, name) => {
+    document.getElementById("qrsku").value = sku;
+    document.getElementById("qrbatch").value = name;
+    document.getElementById("qrform").submit();
+  },
 
   // (I) SHOW WRITE NFC SCREEN
   nfcSKU : null, // current sku to write
@@ -151,6 +155,7 @@ var batch = {
     ]
   })
 };
+
 window.addEventListener("load", () => {
   batch.list();
   autocomplete.attach({

assets/storage-boxx-1.png

@@ -10,11 +10,17 @@ function __construct ($core) {
   // (B) CREATE NEW NFC LOGIN TOKEN
   //  $id : user id
   function add ($id) {
-    // (B1) UPDATE TOKEN
+    // (B1) CHECK VALID USER
+    if (!is_array($this->Users->get($id))) {
+      $this->error = "Invalid user";
+      return false;
+    }
+
+    // (B2) UPDATE TOKEN
     $token = $this->Core->random($this->nlen);
     $this->Users->hashAdd($id, "NFC", password_hash($token, PASSWORD_DEFAULT));
 
-    // (B2) RETURN ENCODED TOKEN
+    // (B3) RETURN ENCODED TOKEN
     require PATH_LIB . "JWT/autoload.php";
     return Firebase\JWT\JWT::encode([$id, $token], JWT_SECRET, JWT_ALGO);
   }

assets/storage-boxx-2.png

@@ -10,11 +10,17 @@ function __construct ($core) {
   // (B) CREATE NEW NFC LOGIN TOKEN
   //  $id : user id
   function add ($id) {
-    // (B1) UPDATE TOKEN
+    // (B1) CHECK VALID USER
+    if (!is_array($this->Users->get($id))) {
+      $this->error = "Invalid user";
+      return false;
+    }
+
+    // (B2) UPDATE TOKEN
     $token = $this->Core->random($this->nlen);
     $this->Users->hashAdd($id, "QR", password_hash($token, PASSWORD_DEFAULT));
 
-    // (B2) RETURN ENCODED TOKEN
+    // (B3) RETURN ENCODED TOKEN
     require PATH_LIB . "JWT/autoload.php";
     return Firebase\JWT\JWT::encode([$id, $token], JWT_SECRET, JWT_ALGO);
   }