adds an importExtension option #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an importExtension option to enable adding the .js extension in import statements for generated files. It updates function signatures, implementation calls, and test cases to accommodate the new option.
- Introduces the importExtension option in generator options and function parameters.
- Updates tests to reflect the new parameter.
- Updates documentation comments to include the importExtension parameter.
Reviewed Changes
Copilot reviewed 14 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/writeClient.spec.ts | Updated test invocation to include the new importExtension flag. |
| src/index.ts | Added the importExtension option to the Options type and generator. |
| src/utils/writeClientIndex.ts | Extended comments and parameters to include importExtension. |
| src/utils/writeClient.ts | Modified function calls to pass the importExtension parameter. |
| src/utils/writeClientModels.spec.ts | Added the importExtension boolean argument in the test. |
| src/utils/writeClientCore.ts | Added the importExtension parameter to the core client generation. |
Files not reviewed (13)
- package.json: Language not supported
- src/templates/core/ApiError.hbs: Language not supported
- src/templates/core/BaseHttpRequest.hbs: Language not supported
- src/templates/core/HttpRequest.hbs: Language not supported
- src/templates/core/OpenAPI.hbs: Language not supported
- src/templates/core/angular/request.hbs: Language not supported
- src/templates/core/axios/request.hbs: Language not supported
- src/templates/core/fetch/request.hbs: Language not supported
- src/templates/core/node/request.hbs: Language not supported
- src/templates/core/xhr/request.hbs: Language not supported
- src/templates/exportModel.hbs: Language not supported
- src/templates/exportService.hbs: Language not supported
- src/templates/index.hbs: Language not supported
inesgomas
previously approved these changes
Mar 25, 2025
nedaKaighobadi
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.