Skip to content

Commit c3eabb2

Browse files
committed
confirm support for CockroachDB 25.4
1 parent cd1d69a commit c3eabb2

File tree

4 files changed

+19
-2
lines changed

4 files changed

+19
-2
lines changed

.github/workflows/tests.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,11 @@ jobs:
5454
use_psycopg2: psycopg2
5555
- crdb-version: v25.3.1
5656
use_server_side_binding: server_side_binding
57+
- crdb-version: v25.4.0
58+
- crdb-version: v25.4.0
59+
use_psycopg2: psycopg2
60+
- crdb-version: v25.4.0
61+
use_server_side_binding: server_side_binding
5762
# Uncomment to enable testing of CockroachDB nightly.
5863
#- crdb-version: LATEST
5964
#- crdb-version: LATEST

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## 5.2.1 - Unreleased
44

5-
- Confirmed support for CockroachDB 25.2.x and 25.3.x (no code changes
5+
- Confirmed support for CockroachDB 25.2.x, 25.3.x, and 25.4.x (no code changes
66
required).
77
- Fixed the ``Now`` database function to use the statement time
88
(``STATEMENT_TIMESTAMP``) rather than the transaction time

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ By default, CockroachDB sends the version of django-cockroachdb that you're
9292
using back to Cockroach Labs. To disable this, set
9393
`DISABLE_COCKROACHDB_TELEMETRY = True` in your Django settings.
9494

95-
## Known issues and limitations in CockroachDB 25.3.x and earlier
95+
## Known issues and limitations in CockroachDB 25.4.x and earlier
9696

9797
- CockroachDB [can't disable constraint checking](https://github.com/cockroachdb/cockroach/issues/19444),
9898
which means certain things in Django like forward references in fixtures

django_cockroachdb/features.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,10 @@ def is_cockroachdb_25_1(self):
9191
def is_cockroachdb_25_2(self):
9292
return self.connection.cockroachdb_version >= (25, 2)
9393

94+
@cached_property
95+
def is_cockroachdb_25_4(self):
96+
return self.connection.cockroachdb_version >= (25, 4)
97+
9498
@cached_property
9599
def django_test_expected_failures(self):
96100
expected_failures = super().django_test_expected_failures
@@ -356,4 +360,12 @@ def django_test_skips(self):
356360
'schema.tests.SchemaTests.test_alter_field_type_and_db_collation',
357361
},
358362
})
363+
if self.is_cockroachdb_25_4:
364+
skips.update({
365+
# Error truncating hundreds of tables:
366+
# https://github.com/cockroachdb/cockroach/issues/156682
367+
'Test fails when run with all apps.': {
368+
'migration_test_data_persistence.tests.MigrationDataPersistenceClassSetup',
369+
},
370+
})
359371
return skips

0 commit comments

Comments
 (0)