drop support for CockroachDB 23.1

Author: timgraham

.github/workflows/tests.yml

@@ -29,11 +29,6 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - crdb-version: v23.1.30
-          - crdb-version: v23.1.30
-            use_psycopg2: psycopg2
-          - crdb-version: v23.1.30
-            use_server_side_binding: server_side_binding
           - crdb-version: v23.2.21
           - crdb-version: v23.2.21
             use_psycopg2: psycopg2

README.md

@@ -147,7 +147,3 @@ using back to Cockroach Labs. To disable this, set
   `unimplemented: table <...> is currently undergoing a schema change` if a
   later operation tries to modify the table before the asynchronous query
   finishes.
-
- ## Known issues and limitations in CockroachDB 23.1.x and earlier
-
-- CockroachDB doesn't support by ordering by JSON.

django_cockroachdb/features.py

@@ -5,7 +5,7 @@
 
 
 class DatabaseFeatures(PostgresDatabaseFeatures):
-    minimum_database_version = (23, 1)
+    minimum_database_version = (23, 2)
 
     # Cloning databases doesn't speed up tests.
     # https://github.com/cockroachdb/django-cockroachdb/issues/206
@@ -75,10 +75,6 @@ def introspected_field_types(self):
         'virtual': None,
     }
 
-    @cached_property
-    def is_cockroachdb_23_2(self):
-        return self.connection.cockroachdb_version >= (23, 2)
-
     @cached_property
     def is_cockroachdb_24_1(self):
         return self.connection.cockroachdb_version >= (24, 1)
@@ -201,28 +197,6 @@ def django_test_expected_failures(self):
                 # concat(): unknown signature: concat(string, int2) (desired <string>)
                 'db_functions.text.test_concat.ConcatTests.test_concat_non_str',
             })
-        if not self.is_cockroachdb_23_2:
-            expected_failures.update({
-                # cannot index a json element:
-                # https://github.com/cockroachdb/cockroach/issues/35706
-                'schema.tests.SchemaTests.test_func_index_json_key_transform',
-                # ordering by JSON isn't supported:
-                # https://github.com/cockroachdb/cockroach/issues/35706
-                'db_functions.comparison.test_json_object.JSONObjectTests.test_order_by_key',
-                'db_functions.comparison.test_json_object.JSONObjectTests.test_order_by_nested_key',
-                'expressions_window.tests.WindowFunctionTests.test_key_transform',
-                'model_fields.test_jsonfield.TestQuerying.test_deep_distinct',
-                'model_fields.test_jsonfield.TestQuerying.test_order_grouping_custom_decoder',
-                'model_fields.test_jsonfield.TestQuerying.test_ordering_by_transform',
-                'model_fields.test_jsonfield.TestQuerying.test_ordering_grouping_by_key_transform',
-                # unsupported comparison operator: <jsonb> > <string>:
-                # https://github.com/cockroachdb/cockroach/issues/49144
-                'model_fields.test_jsonfield.TestQuerying.test_deep_lookup_transform',
-                # DataError: incompatible COALESCE expressions: expected pi() to be
-                # of type decimal, found type float
-                # https://github.com/cockroachdb/cockroach/issues/73587#issuecomment-988408190
-                'aggregation.tests.AggregateTestCase.test_aggregation_default_using_decimal_from_database',
-            })
         if self.is_cockroachdb_24_1:
             # USING cast required: https://github.com/cockroachdb/cockroach/issues/82416#issuecomment-2029803229
             expected_failures.update({