Skip to content

Commit f8042b3

Browse files
committed
Adding Airbnb ESLint rules
Disable usupported rules for specific ember apps. Add a eslint-config-airbnb-base, eslint-plugin-ember, eslint-plugin-import to package.json. Update ember-cli-code-coverage to v1.0.0-beta.4 version to get the fix when using the `useBabelInstrumenter` config see ember-cli-code-coverage/ember-cli-code-coverage#133 . Closes #58
1 parent e14ac25 commit f8042b3

File tree

4 files changed

+279
-121
lines changed

4 files changed

+279
-121
lines changed

.eslintrc.js

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,24 @@ module.exports = {
1010
],
1111
extends: [
1212
'eslint:recommended',
13-
'plugin:ember/recommended'
13+
'plugin:ember/recommended',
14+
'airbnb-base'
1415
],
1516
env: {
1617
browser: true
1718
},
1819
rules: {
20+
// This rule has no support for @ember import system.
21+
// Ember build have their own mechanism to managing dependency.
22+
// Ember build will raise error on build if there is an import error.
23+
'import/extensions': 'off',
24+
'import/no-unresolved': 'off',
25+
'import/no-extraneous-dependencies': 'off',
26+
// Ember use underscore dangling, e.g _super. Which is enforced by ember's
27+
// own linter to be used on init() method.
28+
'no-underscore-dangle': 'off',
29+
// Ember Routes and tests utilize `this` inside their callback.
30+
'prefer-arrow-callback': 'off',
1931
},
2032
overrides: [
2133
// node files

config/coverage.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
/* global module */
2+
3+
'use strict';
4+
5+
module.exports = {
6+
useBabelInstrumenter: true,
7+
};

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"ember-cli": "~3.1.4",
2727
"ember-cli-app-version": "^3.2.0",
2828
"ember-cli-babel": "^6.6.0",
29-
"ember-cli-code-coverage": "^0.4.2",
29+
"ember-cli-code-coverage": "^1.0.0-beta.4",
3030
"ember-cli-dependency-checker": "^2.0.0",
3131
"ember-cli-eslint": "^4.2.1",
3232
"ember-cli-htmlbars": "^2.0.1",
@@ -43,7 +43,9 @@
4343
"ember-paper": "^1.0.0-alpha.19",
4444
"ember-source": "~3.1.0",
4545
"eslint": "^4.19.1",
46+
"eslint-config-airbnb-base": "12.1.0",
4647
"eslint-plugin-ember": "^5.0.0",
48+
"eslint-plugin-import": "^2.7.0",
4749
"github-api": "https://github.com/github-tools/github/archive/v3.1.0.tar.gz",
4850
"loader.js": "^4.2.3",
4951
"remark": "^9.0.0",

0 commit comments

Comments
 (0)