[Tests] Remove defunct test exception handler code

The removed code is no longer required because more recent
versions of Laravel allow use of the `withoutExceptionHandling`
helper.

Author: lindyhopchris

src/Testing/TestExceptionHandler.php

@@ -49,13 +49,6 @@ class TestExceptionHandler extends ExceptionHandler
 
     use HandlesErrors;
 
-    /**
-     * Whether Exceptions should be thrown to PHPUnit to handle.
-     *
-     * @var bool
-     */
-    public $rethrow = true;
-
     /**
      * @var array
      */
@@ -69,9 +62,7 @@ class TestExceptionHandler extends ExceptionHandler
      */
     public function report(Exception $e)
     {
-        if ($this->shouldReport($e) && $this->rethrow) {
-            throw $e;
-        }
+        // no-op
     }
 
     /**

tests/lib/Integration/ErrorsTest.php

@@ -40,15 +40,6 @@ class ErrorsTest extends TestCase
      */
     protected $resourceType = 'posts';
 
-    /**
-     * @return void
-     */
-    protected function setUp(): void
-    {
-        parent::setUp();
-        $this->doNotRethrowExceptions();
-    }
-
     /**
      * Returns a JSON API error for 404.
      */

tests/lib/Integration/Pagination/CursorPagingTest.php

@@ -221,16 +221,14 @@ public function testBeforeWithEqualDates()
 
     /**
      * If the before key does not exist, we expect the cursor builder
-     * to throw an exception. Applications should validate the id
-     * before passing it to the cursor.
+     * to throw an exception which would constitute an internal server error.
+     * Applications should validate the id before passing it to the cursor.
      */
     public function testBeforeDoesNotExist()
     {
-        $this->expectException(\OutOfRangeException::class);
-        $this->expectExceptionMessage('999');
-
         $this->actingAsUser()
-            ->doSearch(['page' => ['before' => '999']]);
+            ->doSearch(['page' => ['before' => '999']])
+            ->assertStatus(500);
     }
 
     public function testAfter()
@@ -456,16 +454,14 @@ public function testAfterWithCustomKey()
 
     /**
      * If the after key does not exist, we expect the cursor builder
-     * to throw an exception. Applications should validate the id
-     * before passing it to the cursor.
+     * to throw an exception which would constitute an internal server error.
+     * Applications should validate the id before passing it to the cursor.
      */
     public function testAfterDoesNotExist()
     {
-        $this->expectException(\OutOfRangeException::class);
-        $this->expectExceptionMessage('999');
-
         $this->actingAsUser()
-            ->doSearch(['page' => ['after' => '999']]);
+            ->doSearch(['page' => ['after' => '999']])
+            ->assertStatus(500);
     }
 
     /**

tests/lib/Integration/TestCase.php

@@ -94,18 +94,6 @@ protected function resolveApplicationExceptionHandler($app)
         $app->singleton(ExceptionHandler::class, TestExceptionHandler::class);
     }
 
-    /**
-     * Set the test exception handler to not re-throw exceptions.
-     *
-     * @return void
-     */
-    protected function doNotRethrowExceptions()
-    {
-        /** @var TestExceptionHandler $handler */
-        $handler = $this->app->make(ExceptionHandler::class);
-        $handler->rethrow = false;
-    }
-
     /**
      * Use the default dummy app routes.
      *