CLJS-2731: Failure comparing sorted sets

Catch comparison errors in PersistentTreeSet and PersistentHashSet .-equiv when compared with sorted sets.

Author: jeremyrsellars

src/main/cljs/cljs/core.cljs

@@ -9085,9 +9085,12 @@ reduces them without incurring seq initialization"
      (set? other)
      (== (count coll) (count other))
      ^boolean
-     (reduce-kv
-       #(or (contains? other %2) (reduced false))
-       true hash-map)))
+     (try
+       (reduce-kv
+         #(or (contains? other %2) (reduced false))
+         true hash-map)
+       (catch js/Error ex
+         false))))
 
   IHash
   (-hash [coll] (caching-hash coll hash-unordered-coll __hash))
@@ -9236,9 +9239,12 @@ reduces them without incurring seq initialization"
      (set? other)
      (== (count coll) (count other))
      ^boolean
-     (reduce-kv
-       #(or (contains? other %2) (reduced false))
-       true tree-map)))
+     (try
+       (reduce-kv
+         #(or (contains? other %2) (reduced false))
+         true tree-map)
+       (catch js/Error ex
+         false))))
 
   IHash
   (-hash [coll] (caching-hash coll hash-unordered-coll __hash))

src/test/cljs/cljs/set_equiv_test.cljs

@@ -0,0 +1,18 @@
+(ns cljs.set-equiv-test
+  (:refer-clojure :exclude [iter])
+  (:require [cljs.test :refer-macros [deftest testing is]]
+            [clojure.string :as s]
+            [clojure.set :as set]))
+
+(deftest test-set-equality
+  (testing "Testing set equality"
+    (is (= (sorted-set 3 2 1)    (sorted-set 1 2 3)))
+    (is (= (hash-set   3 2 1)    (sorted-set 1 2 3)))
+    (is (= (sorted-set :a :b :c) (hash-set :a :b :c)))
+    (is (= (hash-set   :a :b :c) (hash-set :a :b :c))))
+
+  (testing "CLJS-2731 uncomparable values"
+    (is (not= (sorted-set 3 2 1) (sorted-set :a :b :c)))
+    (is (not= (hash-set 3 2 1)   (sorted-set :a :b :c)))
+    (is (not= (sorted-set 3 2 1) (hash-set   :a :b :c)))
+    (is (not= (hash-set 3 2 1)   (hash-set   :a :b :c)))))

src/test/self/self_parity/test.cljs

@@ -303,6 +303,7 @@
                  [cljs.clojure-alias-test]
                  [cljs.hash-map-test]
                  [cljs.map-entry-test]
+                 [cljs.set-equiv-test]
                  [cljs.syntax-quote-test]
                  [cljs.predicates-test]
                  [cljs.test-test]
@@ -345,6 +346,7 @@
              'cljs.clojure-alias-test
              'cljs.hash-map-test
              'cljs.map-entry-test
+             'cljs.set-equiv-test
              'cljs.syntax-quote-test
              'cljs.predicates-test
              'cljs.test-test