CLJS-1617: Evaluation order of arguments to 'list' is right-to-left

don't optimize list construction unless we have constants

Author: dnolen

src/main/clojure/cljs/core.cljc

@@ -2377,9 +2377,13 @@
      assoc :tag 'array)))
 
 (core/defmacro list
-  ([] '(.-EMPTY cljs.core/List))
+  ([]
+   '(.-EMPTY cljs.core/List))
   ([x & xs]
-    `(-conj (list ~@xs) ~x)))
+   (if (= :constant (:op (cljs.analyzer/analyze &env x)))
+     `(-conj (list ~@xs) ~x)
+     `(let [x# ~x]
+        (-conj (list ~@xs) x#)))))
 
 (core/defmacro vector
   ([] '(.-EMPTY cljs.core/PersistentVector))