fix(e2e): simplify billing tests and fix environment configuration

Simplified billing-related integration tests by removing explicit environment
constraints. Tests now run against the default withBilling environment instead
of requiring explicit withEnv configuration, reducing test setup complexity.

Fixed withBillingJwtV2 environment configuration:
- Removed staging API URL override (now uses default production API)
- Changed from 'with-billing-staging' to 'with-billing' instance keys
- This aligns the test environment with the production billing setup

Added CLERK_JS_URL and CLERK_UI_URL to withCustomRoles environment to support
local development and CI testing scenarios where custom Clerk script URLs
are needed.

Also fixed minor typo in test name and removed extraneous blank line.

Author: nikosdouvlis

integration/presets/envs.ts

@@ -65,7 +65,9 @@ const withCustomRoles = base
   .clone()
   .setId('withCustomRoles')
   .setEnvVariable('private', 'CLERK_SECRET_KEY', instanceKeys.get('with-custom-roles').sk)
-  .setEnvVariable('public', 'CLERK_PUBLISHABLE_KEY', instanceKeys.get('with-custom-roles').pk);
+  .setEnvVariable('public', 'CLERK_PUBLISHABLE_KEY', instanceKeys.get('with-custom-roles').pk)
+  .setEnvVariable('public', 'CLERK_JS_URL', constants.E2E_APP_CLERK_JS || 'http://localhost:18211/clerk.browser.js')
+  .setEnvVariable('public', 'CLERK_UI_URL', constants.E2E_APP_CLERK_UI || 'http://localhost:18212/ui.browser.js');
 
 const withReverification = base
   .clone()
@@ -165,9 +167,8 @@ const withSessionTasksResetPassword = base
 const withBillingJwtV2 = base
   .clone()
   .setId('withBillingJwtV2')
-  .setEnvVariable('private', 'CLERK_API_URL', 'https://api.clerkstage.dev')
-  .setEnvVariable('private', 'CLERK_SECRET_KEY', instanceKeys.get('with-billing-staging').sk)
-  .setEnvVariable('public', 'CLERK_PUBLISHABLE_KEY', instanceKeys.get('with-billing-staging').pk);
+  .setEnvVariable('private', 'CLERK_SECRET_KEY', instanceKeys.get('with-billing').sk)
+  .setEnvVariable('public', 'CLERK_PUBLISHABLE_KEY', instanceKeys.get('with-billing').pk);
 
 const withBilling = base
   .clone()

integration/tests/billing-hooks.test.ts

@@ -1,10 +1,9 @@
 import { expect, test } from '@playwright/test';
 
-import { appConfigs } from '../presets';
 import type { FakeUser } from '../testUtils';
 import { createTestUtils, testAgainstRunningApps } from '../testUtils';
 
-testAgainstRunningApps({ withEnv: [appConfigs.envs.withBilling] })('billing hooks @billing', ({ app }) => {
+testAgainstRunningApps({})('billing hooks @billing', ({ app }) => {
   test.describe.configure({ mode: 'parallel' });
   test.skip(!app.name.includes('next'), 'Skipping: Only runs on next');
 

integration/tests/pricing-table.test.ts

@@ -1,11 +1,10 @@
 import type { Locator } from '@playwright/test';
 import { expect, test } from '@playwright/test';
 
-import { appConfigs } from '../presets';
 import type { FakeUser } from '../testUtils';
 import { createTestUtils, testAgainstRunningApps } from '../testUtils';
 
-testAgainstRunningApps({ withEnv: [appConfigs.envs.withBilling] })('pricing table @billing', ({ app }) => {
+testAgainstRunningApps({})('pricing table @billing', ({ app }) => {
   test.describe.configure({ mode: 'parallel' });
 
   let fakeUser: FakeUser;
@@ -639,7 +638,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withBilling] })('pricing tabl
       await fakeUser.deleteIfExists();
     });
 
-    test('displays notice then plan cannot change', async ({ page, context }) => {
+    test('displays notice the plan cannot change', async ({ page, context }) => {
       const u = createTestUtils({ app, page, context });
 
       const fakeUser = u.services.users.createFakeUser();
@@ -657,7 +656,6 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withBilling] })('pricing tabl
       await u.po.checkout.fillTestCard();
       await u.po.checkout.clickPayOrSubscribe();
       await expect(u.po.page.getByText('Payment was successful!')).toBeVisible();
-
       await u.po.checkout.confirmAndContinue();
       await u.po.pricingTable.startCheckout({ planSlug: 'pro', shouldSwitch: true, period: 'monthly' });
       await u.po.checkout.waitForMounted();