feat(ci): add clippy check to ci

Author: clearloop

.github/workflows/clippy.yml

@@ -0,0 +1,25 @@
+name: Clippy Check
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  clippy:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [macOS-latest, ubuntu-latest]
+    steps:
+      - uses: actions/checkout@v1
+      - uses: actions-rs/toolchain@v1
+        with:
+            toolchain: stable
+            components: clippy
+            override: true
+      - uses: actions-rs/clippy-check@v1
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          args: --all-features

src/cache/models.rs

@@ -57,15 +57,15 @@ impl std::fmt::Display for Problem {
             1 => {
                 id.push_str(&SPACE.repeat(2));
                 id.push_str(&self.fid.to_string());
-                id.push_str(&SPACE.repeat(1));
+                id.push_str(&SPACE.to_string());
             }
             2 => {
-                id.push_str(&SPACE.repeat(1));
+                id.push_str(&SPACE.to_string());
                 id.push_str(&self.fid.to_string());
-                id.push_str(&SPACE.repeat(1));
+                id.push_str(&SPACE.to_string());
             }
             3 => {
-                id.push_str(&SPACE.repeat(1));
+                id.push_str(&SPACE.to_string());
                 id.push_str(&self.fid.to_string());
             }
             4 => {
@@ -304,26 +304,30 @@ impl std::fmt::Display for VerifyResult {
                     }
                     write!(
                         f,
-                        "\n{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}.\n\n",
+                        "\n{}{}{}\
+                         , faster than \
+                         {}{}\
+                         of \
+                         {} \
+                         online submissions for \
+                         {}.\n\n\
+                         {}{}\
+                         , less than \
+                         {}{} \
+                         of \
+                         {}{}.\n\n",
                         "Success\n\n".green().bold(),
                         "Runtime: ".dimmed(),
                         &self.status.status_runtime.bold(),
-                        ", faster than ",
                         rp.to_string().bold(),
                         "% ".bold(),
-                        "of ",
                         &self.pretty_lang,
-                        " online submissions for ",
                         &self.name,
-                        ".\n\n",
                         "Memory Usage: ".dimmed(),
                         &self.status.status_memory.bold(),
-                        ", less than ",
                         mp.to_string().bold(),
                         "% ".bold(),
-                        "of ",
                         &self.pretty_lang,
-                        " online submissions for ",
                         &self.name,
                     )?
                 } else {
@@ -400,7 +404,7 @@ impl std::fmt::Display for VerifyResult {
 
         match &self.result_type {
             Run::Test => {
-                if &self.code_output.len() > &0 {
+                if !self.code_output.is_empty() {
                     write!(
                         f,
                         "{}{}",
@@ -412,7 +416,7 @@ impl std::fmt::Display for VerifyResult {
                 }
             }
             _ => {
-                if &self.std_output.len() > &0 {
+                if !self.std_output.is_empty() {
                     write!(
                         f,
                         "{}{}",
@@ -510,19 +514,19 @@ mod verify {
 
 /// Formatter for str
 trait Formatter {
-    fn after_spaces<'f>(&self, spaces: usize) -> String;
-    fn before_spaces<'f>(&self, spaces: usize) -> String;
+    fn after_spaces(&self, spaces: usize) -> String;
+    fn before_spaces(&self, spaces: usize) -> String;
 }
 
 impl Formatter for str {
-    fn after_spaces<'f>(&self, spaces: usize) -> String {
+    fn after_spaces(&self, spaces: usize) -> String {
         let mut r = String::new();
         r.push_str(self);
         r.push_str(&" ".repeat(spaces));
         r
     }
 
-    fn before_spaces<'f>(&self, spaces: usize) -> String {
+    fn before_spaces(&self, spaces: usize) -> String {
         let mut r = String::new();
         r.push_str(&" ".repeat(spaces));
         r.push_str(self);

src/cli.rs

@@ -36,7 +36,11 @@ pub fn main() -> Result<(), Error> {
             .init();
     }
 
-    let mut runtime = Builder::new().build().unwrap();
+    let mut runtime = Builder::new()
+        .basic_scheduler()
+        .enable_all()
+        .build()
+        .unwrap();
     match m.subcommand() {
         ("data", Some(sub_m)) => Ok(DataCommand::handler(sub_m, &mut runtime)?),
         ("edit", Some(sub_m)) => Ok(EditCommand::handler(sub_m, &mut runtime)?),

src/cmds/list.rs

@@ -125,11 +125,11 @@ impl Command for ListCommand {
         trace!("Input list command...");
 
         let cache = Cache::new()?;
-        let mut ps = cache.clone().get_problems()?;
+        let mut ps = cache.get_problems()?;
 
         // if cache doesn't exist, request a new copy
         if ps.is_empty() {
-            runtime.block_on(cache.clone().download_problems())?;
+            runtime.block_on(cache.download_problems())?;
             return Self::handler(m, runtime);
         }
 

src/cmds/test.rs

@@ -49,7 +49,7 @@ impl Command for TestCommand {
         let testcase = m.value_of("testcase");
         let case_str: Option<String>;
         match testcase {
-            Some(case) => case_str = Option::from(case.replace("\\n", "\n").to_string()),
+            Some(case) => case_str = Option::from(case.replace("\\n", "\n")),
             _ => case_str = None,
         }
         let cache = Cache::new()?;

src/err.rs

@@ -25,15 +25,16 @@ impl std::fmt::Debug for Error {
             Error::CacheError(s) => write!(f, "{} {}, please try again", e, s),
             Error::CookieError => write!(
                 f,
-                "{} {}{}{}{}{}",
+                "{} \
+                 Your leetcode cookies seems expired, \
+                 {} \
+                 Either you can handwrite your `LEETCODE_SESSION` and `csrf` into `leetcode.toml`, \
+                 more info please checkout this: \
+                 https://github.com/clearloop/leetcode-cli/blob/master/README.md#cookies",
                 e,
-                "Your leetcode cookies seems expired, ",
                 "please make sure you have logined in leetcode.com with chrome. "
                     .yellow()
                     .bold(),
-                "Either you can handwrite your `LEETCODE_SESSION` and `csrf` into `leetcode.toml`, ",
-                "more info please checkout this: ",
-                "https://github.com/clearloop/leetcode-cli/blob/master/README.md#cookies"
             ),
             Error::DownloadError(s) => write!(f, "{} Download {} failed, please try again", e, s),
             Error::NetworkError(s) => write!(f, "{} {}, please try again", e, s),

src/helper.rs

@@ -124,17 +124,17 @@ mod html {
             8 => "⁸".to_string(),
             9 => "⁹".to_string(),
             x if x > 10 => (superscript(n / 10).parse().unwrap_or(0)
-                + &superscript(n % 10).parse().unwrap_or(0))
-                .to_string(),
+                + superscript(n % 10).parse().unwrap_or(0))
+            .to_string(),
             _ => n.to_string(),
         }
     }
 
     pub fn subscript(n: u8) -> String {
         match n {
             x if x >= 10 => (subscript(n / 10).parse().unwrap_or(0)
-                + &subscript(n % 10).parse().unwrap_or(0))
-                .to_string(),
+                + subscript(n % 10).parse().unwrap_or(0))
+            .to_string(),
             0 => "₀".to_string(),
             1 => "₁".to_string(),
             2 => "₂".to_string(),