From 9c94f7df776c2575072b285dbb27bf4d4420d049 Mon Sep 17 00:00:00 2001 From: RetricSu Date: Tue, 30 Dec 2025 14:48:07 +0800 Subject: [PATCH 1/2] fix: portable ckb is not available on windows (#347) --- src/node/install.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/node/install.ts b/src/node/install.ts index dbb8136..54c12ed 100644 --- a/src/node/install.ts +++ b/src/node/install.ts @@ -178,7 +178,8 @@ function buildCKBGithubReleasePackageName(version: string, opt: { os?: string; a const os = opt.os || getOS(); const arch = opt.arch || getArch(); - if (isPortable()) { + if (isPortable() && os !== 'pc-windows-msvc') { + // portable binary is not available for windows return `ckb_v${version}_${arch}-${os}-portable`; } else { return `ckb_v${version}_${arch}-${os}`; @@ -193,7 +194,8 @@ function buildCKBGithubReleasePackageNameWithExtension( const arch = opt.arch || getArch(); const extension = opt.ext || getExtension(); - if (isPortable()) { + if (isPortable() && os !== 'pc-windows-msvc') { + // portable binary is not available for windows return `ckb_v${version}_${arch}-${os}-portable.${extension}`; } else { return `ckb_v${version}_${arch}-${os}.${extension}`; From bee6fc04c8d0b4a8f38ab90c2fc24be2e9099351 Mon Sep 17 00:00:00 2001 From: RetricSu Date: Tue, 30 Dec 2025 15:52:53 +0800 Subject: [PATCH 2/2] chore: add log for downloading (#349) --- src/node/install.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/node/install.ts b/src/node/install.ts index 54c12ed..64f2e26 100644 --- a/src/node/install.ts +++ b/src/node/install.ts @@ -50,8 +50,8 @@ export async function downloadCKBBinaryAndUnzip(version: string) { fs.chmodSync(getCKBBinaryPath(version), '755'); // Make the binary executable logger.info(`CKB ${version} installed successfully.`); - } catch (error) { - logger.error('Error installing dependency binary:', error); + } catch (error: unknown) { + logger.error('Error installing dependency binary:', (error as Error).message); } }