Add version check for charts when there are changes (#108)

* Enable validation on the Postgres chart

* Add version check for charts when there are changes

Author: christian-stephen

.circleci/config.yml

@@ -17,18 +17,25 @@ executors:
           password: $DOCKER_HUB_PASSWORD
 
 commands:
-  notify_failing_main:
+  notify_failing_branch:
     steps:
       - slack/notify:
           channel: server-alerts
-          branch_pattern: main
+          branch_pattern: main, server-[0-9]\.[0-9]+
           event: fail
           template: basic_fail_1
   set_up_container:
     description: "Set up a container build environment"
     steps:
       - setup_remote_docker
       - checkout
+  install_packagecloud_cli:
+    steps:
+      - run:
+          name: Install package_cloud
+          command: |
+            sudo apt-get update && sudo apt-get install ruby-rubygems -y
+            sudo gem install --no-document package_cloud
 
 jobs:
   # Images
@@ -116,7 +123,7 @@ jobs:
       - run:
           command: ./do kubeconform
           when: always
-      - notify_failing_main
+      - notify_failing_branch
   package-charts:
     executor: deploy
     steps:
@@ -144,7 +151,14 @@ jobs:
       - persist_to_workspace:
           root: .
           paths: [./target]
-      - notify_failing_main
+      - notify_failing_branch
+  check-version-bump:
+    executor: deploy
+    steps:
+      - checkout
+      - run:
+          name: Check if charts changed and version is bumped accordingly
+          command: ./do check-version-bump
   publish-chart:
     executor: deploy
     parameters:
@@ -156,17 +170,14 @@ jobs:
       - checkout
       - attach_workspace:
           at: .
-      - run:
-          name: Install package_cloud
-          command: |
-            sudo apt-get update && sudo apt-get install ruby-rubygems -y
-            sudo gem install --no-document package_cloud
+      - install_packagecloud_cli
       - run:
           name: Publish Helm chart
           command: |
             package_cloud push circleci/<< parameters.repo >>/helm/v1 \
               ./target/<< parameters.chart_name >>*.tgz
-      - notify_failing_main
+      - notify_failing_branch
+
 
 workflows:
   my-workflow:
@@ -231,9 +242,10 @@ workflows:
 
       # Chart jobs
       - validate-charts
+      - check-version-bump
       - package-charts:
           context: releng-signing
-          requires: [validate-charts]
+          requires: [validate-charts, check-version-bump]
       # Mongo chart
       - approve-publish-mongo-chart:
           type: approval

do

@@ -11,9 +11,7 @@ kubeconform() {
 
     for chart_dir in ./helm/*/; do
         if [[ -f "$chart_dir/Chart.yaml" ]]; then
-            # TODO: Skip postgresql chart - failing validation
-            if [[ "$chart_dir" == *"postgresql"* ||  "$chart_dir" == *"common"* ]]; then
-                echo "Skipping chart: $chart_dir (TODO: fix validation issues)"
+            if [[ "$chart_dir" == *"common"* ]]; then
                 continue
             fi
 
@@ -87,6 +85,40 @@ package-all-charts() {
     done
 }
 
+# This variable is used, but shellcheck can't tell.
+# shellcheck disable=SC2034
+help_check_version_bump="Check if charts changed and version is bumped accordingly"
+check-version-bump() {
+  for chart_yaml in ./helm/*/Chart.yaml; do
+    if [[ -f "${chart_yaml}" ]]; then
+      chart_dir=$(dirname "${chart_yaml}" | sed 's|^\./||')
+
+      if git diff --name-only HEAD~1 HEAD | grep -q "^${chart_dir}/"; then
+        version=$(grep '^version:' "${chart_yaml}" | awk '{print $2}' | tr -d '"')
+        name=$(grep '^name:' "${chart_yaml}" | awk '{print $2}' | tr -d '"')
+
+        case "${name}" in
+          mongodb) repo="server-mongo" ;;
+          postgresql) repo="server-postgres" ;;
+          rabbitmq) repo="server-rabbitmq" ;;
+          redis) repo="server-redis" ;;
+          *) echo "Unknown chart: ${name}"; exit 1 ;;
+        esac
+
+        echo "Chart ${name} changed, checking version ${version} in Packagecloud"
+
+        if curl -sf "https://${PACKAGECLOUD_TOKEN}:@packagecloud.io/api/v1/repos/circleci/${repo}/search.json?q=${version}" | grep -q "\"filename\":\"${name}-${version}.tgz\""; then
+          echo "Error: ${name}-${version} already exists. Please bump version in ${chart_yaml}"
+          exit 1
+        elif [[ "${CIRCLE_BRANCH:-}" =~ ^server-[0-9]+\.[0-9]+$ && ! "${version}" =~ -${CIRCLE_BRANCH}$ ]]; then
+          echo "Error: Version ${version} should be suffixed with -${CIRCLE_BRANCH} for branch ${CIRCLE_BRANCH}"
+          exit 1
+        fi
+      fi
+    fi
+  done
+}
+
 check-helm() {
     if ! [ -x "$(command -v helm)" ]; then
         echo 'Helm is required. See: https://helm.sh/docs/intro/install/'