Skip to content

Commit 9dbc557

Browse files
author
Christian Elies
committed
refactor(): removed unnecessary equatable conformance
1 parent 162430d commit 9dbc557

File tree

2 files changed

+6
-21
lines changed

2 files changed

+6
-21
lines changed

Sources/RemoteImage/private/Models/RemoteImageState.swift

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,22 +9,7 @@
99
import Foundation
1010

1111
enum RemoteImageState {
12-
case error(_ error: Error)
12+
case error(_ error: NSError)
1313
case image(_ image: PlatformSpecificImageType)
1414
case loading
1515
}
16-
17-
extension RemoteImageState: Equatable {
18-
static func == (lhs: RemoteImageState, rhs: RemoteImageState) -> Bool {
19-
switch (lhs, rhs) {
20-
case (.error(let lhsError), .error(let rhsError)):
21-
return (lhsError as NSError) == (rhsError as NSError)
22-
case (.image(let lhsImage), .image(let rhsImage)):
23-
return lhsImage == rhsImage
24-
case (.loading, .loading):
25-
return true
26-
default:
27-
return false
28-
}
29-
}
30-
}

Sources/RemoteImage/public/Services/RemoteImageService.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,16 +57,16 @@ extension RemoteImageService {
5757
.receive(on: RunLoop.main)
5858
.sink(receiveCompletion: { completion in
5959
switch completion {
60-
case .failure(let failure):
61-
self.state = .error(failure)
60+
case .failure(let error):
61+
self.state = .error(error as NSError)
6262
default: ()
6363
}
6464
}) { image in
6565
if let image = image {
6666
Self.cache.setObject(image, forKey: cacheKey)
6767
self.state = .image(image)
6868
} else {
69-
self.state = .error(RemoteImageServiceError.couldNotCreateImage)
69+
self.state = .error(RemoteImageServiceError.couldNotCreateImage as NSError)
7070
}
7171
}
7272
}
@@ -85,10 +85,10 @@ extension RemoteImageService {
8585
Self.cache.setObject(image, forKey: cacheKey)
8686
self.state = .image(image)
8787
} else {
88-
self.state = .error(RemoteImageServiceError.couldNotCreateImage)
88+
self.state = .error(RemoteImageServiceError.couldNotCreateImage as NSError)
8989
}
9090
case .failure(let error):
91-
self.state = .error(error)
91+
self.state = .error(error as NSError)
9292
}
9393
}
9494
}

0 commit comments

Comments
 (0)