Merge pull request #7167 from christianbeeznest/fixes-updates198

Settings: Remove deprecated 'icons_mode_svg' setting from settings.

Author: christianbeeznest

public/main/inc/lib/display.lib.php

@@ -714,7 +714,7 @@ public static function return_icon(
         // it checks if there is an SVG version. If so, it uses it.
         // When moving this to production, the return_icon() calls should
         // ask for the SVG version directly
-        $svgIcons = api_get_setting('icons_mode_svg');
+        $svgIcons = 'true';
         if ('true' == $svgIcons && false == $return_only_path) {
             $svgImage = substr($image, 0, -3).'svg';
             if (is_file($code_path.$theme.'svg/'.$svgImage)) {

src/CoreBundle/DataFixtures/SettingsCurrentFixtures.php

@@ -687,11 +687,6 @@ public static function getExistingSettings(): array
                     'title' => 'Hide logout button',
                     'comment' => 'Hide the logout button. This is usually only interesting when using an external login/logout method, for example when using Single Sign On of some sort.',
                 ],
-                [
-                    'name' => 'icons_mode_svg',
-                    'title' => 'SVG icons mode',
-                    'comment' => 'By enabling this option, all icons that have an SVG version will prefer the SVG format to PNG. This will give a much better icons quality but some icons might still have some rendering size issue, and some browsers might not support it.',
-                ],
             ],
             'language' => [
                 [

src/CoreBundle/Helpers/ChamiloHelper.php

@@ -113,17 +113,13 @@ public static function getPlatformLogoPath(
             }
             $themeDir = Template::getThemeDir($theme);
             $customLogoPath = $themeDir.\sprintf('images/header-logo-custom%s.png', $accessUrlId);
-
-            $svgIcons = api_get_setting('icons_mode_svg');
-            if ('true' === $svgIcons) {
-                $customLogoPathSVG = substr($customLogoPath, 0, -3).'svg';
-                if (file_exists(api_get_path(SYS_PUBLIC_PATH).\sprintf('css/%s', $customLogoPathSVG))) {
-                    if ($getSysPath) {
-                        return api_get_path(SYS_PUBLIC_PATH).\sprintf('css/%s', $customLogoPathSVG);
-                    }
-
-                    return api_get_path(WEB_CSS_PATH).$customLogoPathSVG;
+            $customLogoPathSVG = substr($customLogoPath, 0, -3).'svg';
+            if (file_exists(api_get_path(SYS_PUBLIC_PATH).\sprintf('css/%s', $customLogoPathSVG))) {
+                if ($getSysPath) {
+                    return api_get_path(SYS_PUBLIC_PATH).\sprintf('css/%s', $customLogoPathSVG);
                 }
+
+                return api_get_path(WEB_CSS_PATH).$customLogoPathSVG;
             }
             if (file_exists(api_get_path(SYS_PUBLIC_PATH).\sprintf('css/%s', $customLogoPath))) {
                 if ($getSysPath) {

src/CoreBundle/Migrations/Schema/V200/Version20251213184300.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+/* For licensing terms, see /license.txt */
+
+namespace Chamilo\CoreBundle\Migrations\Schema\V200;
+
+use Chamilo\CoreBundle\Migrations\AbstractMigrationChamilo;
+use Doctrine\DBAL\Schema\Schema;
+
+final class Version20251213184300 extends AbstractMigrationChamilo
+{
+    public function getDescription(): string
+    {
+        return "Remove deprecated 'icons_mode_svg' setting from settings.";
+    }
+
+    public function up(Schema $schema): void
+    {
+        $this->addSql("DELETE FROM settings WHERE variable = 'icons_mode_svg'");
+    }
+
+    public function down(Schema $schema): void
+    {
+        // Intentionally left empty: the setting is removed from code/schema.
+    }
+}

src/CoreBundle/Settings/DisplaySettingsSchema.php

@@ -53,9 +53,7 @@ public function buildSettings(AbstractSettingsBuilder $builder): void
                     'show_hot_courses' => 'true',
                     'hide_home_top_when_connected' => 'false',
                     'hide_logout_button' => 'false',
-                    'icons_mode_svg' => 'false',
                     'hide_social_media_links' => 'false',
-
                     'gravatar_enabled' => 'false',
                     'gravatar_type' => 'mm',
                     'order_user_list_by_official_code' => 'false',
@@ -124,7 +122,6 @@ public function buildForm(FormBuilderInterface $builder): void
             ->add('show_hot_courses', YesNoType::class)
             ->add('hide_home_top_when_connected', YesNoType::class)
             ->add('hide_logout_button', YesNoType::class)
-            ->add('icons_mode_svg', YesNoType::class)
             ->add('hide_social_media_links', YesNoType::class)
             ->add('gravatar_enabled', YesNoType::class)
             ->add(