Exercise: Prevent showing any "open" answer type in adaptative tests, as we need immediate feedback to be feasible - refs #6195

Author: ywarnier

public/main/exercise/question.class.php

@@ -1551,11 +1551,29 @@ public static function displayTypeMenu(Exercise $objExercise)
                 // Add all other non-open question types.
                 $allTypes = self::getQuestionTypeList();
 
-                // The task explicitly mentions NOT including free-answer questions.
-                // So we only exclude FREE_ANSWER here.
+                // Exclude the classic open question types from the filter list
+                // as the system cannot provide immediate feedback on these.
                 if (isset($allTypes[FREE_ANSWER])) {
                     unset($allTypes[FREE_ANSWER]);
                 }
+                if (isset($allTypes[ORAL_EXPRESSION])) {
+                    unset($allTypes[ORAL_EXPRESSION]);
+                }
+                if (isset($allTypes[ANNOTATION])) {
+                    unset($allTypes[ANNOTATION]);
+                }
+                if (isset($allTypes[MULTIPLE_ANSWER_TRUE_FALSE_DEGREE_CERTAINTY])) {
+                    unset($allTypes[MULTIPLE_ANSWER_TRUE_FALSE_DEGREE_CERTAINTY]);
+                }
+                if (isset($allTypes[UPLOAD_ANSWER])) {
+                    unset($allTypes[UPLOAD_ANSWER]);
+                }
+                if (isset($allTypes[ANSWER_IN_OFFICE_DOC])) {
+                    unset($allTypes[ANSWER_IN_OFFICE_DOC]);
+                }
+                if (isset($allTypes[PAGE_BREAK])) {
+                    unset($allTypes[PAGE_BREAK]);
+                }
 
                 // Append remaining types, without overriding the original ones.
                 foreach ($allTypes as $typeId => $def) {

public/main/exercise/question_pool.php

@@ -445,10 +445,30 @@ function confirm_your_choice() {
         // Start from all known types.
         $allTypes = $question_list;
 
-        // Exclude the classic open question type from the filter list.
+        // Exclude the classic open question types from the filter list
+        // as the system cannot provide immediate feedback on these.
         if (isset($allTypes[FREE_ANSWER])) {
             unset($allTypes[FREE_ANSWER]);
         }
+        if (isset($allTypes[ORAL_EXPRESSION])) {
+            unset($allTypes[ORAL_EXPRESSION]);
+        }
+        if (isset($allTypes[ANNOTATION])) {
+            unset($allTypes[ANNOTATION]);
+        }
+        if (isset($allTypes[MULTIPLE_ANSWER_TRUE_FALSE_DEGREE_CERTAINTY])) {
+            unset($allTypes[MULTIPLE_ANSWER_TRUE_FALSE_DEGREE_CERTAINTY]);
+        }
+        if (isset($allTypes[UPLOAD_ANSWER])) {
+            unset($allTypes[UPLOAD_ANSWER]);
+        }
+        if (isset($allTypes[ANSWER_IN_OFFICE_DOC])) {
+            unset($allTypes[ANSWER_IN_OFFICE_DOC]);
+        }
+        if (isset($allTypes[PAGE_BREAK])) {
+            unset($allTypes[PAGE_BREAK]);
+        }
+
 
         // Append remaining non-open types (do not override base ones).
         foreach ($allTypes as $key => $item) {