Webservice: update_user_from_username: Add 'new_login_name' to allow changing the username - refs BT#21321

Author: ywarnier

main/inc/lib/webservices/Rest.php

@@ -2604,6 +2604,13 @@ public function updateUserFromUserName(array $parameters): bool
             self::throwNotAllowedException();
         }
 
+        if (!empty($parameters['new_login_name'])) {
+            // Make sure the new username, if set, is available
+            if (!UserManager::is_username_available($parameters['new_login_name'])) {
+                throw new Exception(get_lang('LoginAlreadyTaken'));
+            }
+        }
+
         /** @var User $user */
         $user = UserManager::getRepository()->find($userId);
         if (empty($user)) {
@@ -2631,6 +2638,9 @@ public function updateUserFromUserName(array $parameters): bool
                 case 'firstname':
                     $user->setFirstname($value);
                     break;
+                case 'new_login_name':
+                    $user->setUsername($value);
+                    break;
                 case 'phone':
                     $user->setPhone($value);
                     break;