[MERGE #5622 @rhuanjl] Implement Object.fromEntries

Merge pull request #5622 from rhuanjl:ObjectfromEntries

This PR implements the stage 3 proposal Object.fromEntries.
Proposal spec text is here: https://tc39.github.io/proposal-object-from-entries/

Notes:
1. Implementation done as a JsBuiltin - note this requires initialising the JsBuiltins for accessing the Object constructor - could this have negative effects?
2. This implementation passes the test262 tests for this feature.

fixes: #5590

Author: jackhorton

lib/Parser/rterrors.h

@@ -303,7 +303,8 @@ RT_ERROR_MSG(JSERR_ObjectIsNotInitialized, 5617, "%s: Object internal state is n
 
 RT_ERROR_MSG(JSERR_GeneratorAlreadyExecuting, 5618, "%s: Cannot execute generator function because it is currently executing", "", kjstTypeError, 0)
 RT_ERROR_MSG(JSERR_LengthIsTooBig, 5619, "Length property would exceed maximum value in output from '%s'", "", kjstTypeError, 0)
-// 5620-5626 Unused
+RT_ERROR_MSG(JSERR_NonObjectFromIterable, 5620, "Iterable provided to %s must not return non-object or null value.", "", kjstTypeError, 0)
+// 5621-5626 Unused
 RT_ERROR_MSG(JSERR_NeedConstructor, 5627, "'%s' is not a constructor", "Constructor expected", kjstTypeError, 0)
 
 RT_ERROR_MSG(VBSERR_CantDisplayDate, 32812, "", "The specified date is not available in the current locale's calendar", kjstRangeError, 0)

lib/Runtime/Base/JnDirectFields.h

@@ -156,6 +156,7 @@ ENTRY(freeze)
 ENTRY(from)
 ENTRY(fromCharCode)
 ENTRY(fromCodePoint)
+ENTRY(fromEntries)
 ENTRY(function)
 ENTRY(Function)
 ENTRY(getDate)
@@ -611,6 +612,7 @@ ENTRY(InitInternalProperties)
 ENTRY(methodName)
 ENTRY(registerChakraLibraryFunction)
 ENTRY(registerFunction)
+ENTRY(staticMethod)
 ENTRY(toLength)
 ENTRY(toInteger)
 ENTRY(arraySpeciesCreate)
@@ -672,6 +674,7 @@ ENTRY(raiseNeedObject)
 ENTRY(raiseNeedObjectOfType)
 ENTRY(raiseNeedObjectOrString)
 ENTRY(raiseNotAConstructor)
+ENTRY(raiseNonObjectFromIterable)
 ENTRY(raiseObjectIsAlreadyInitialized)
 ENTRY(raiseObjectIsNonExtensible)
 ENTRY(raiseOptionValueOutOfRange_3)

lib/Runtime/ByteCode/ByteCodeCacheReleaseFileVersion.h

@@ -5,6 +5,6 @@
 // NOTE: If there is a merge conflict the correct fix is to make a new GUID.
 // This file was generated with tools\update_bytecode_version.ps1
 
-// {6CC5964E-CBF2-4053-99DA-987794182D7E}
+// {BAC3A947-4873-4DAF-AC60-915116FFE744}
 const GUID byteCodeCacheReleaseFileVersion =
-{ 0x6CC5964E, 0xCBF2, 0x4053, { 0x99, 0xDA, 0x98, 0x77, 0x94, 0x18, 0x2D, 0x7E } };
+{ 0xBAC3A947, 0x4873, 0x4DAF, { 0xAC, 0x60, 0x91, 0x51, 0x16, 0xFF, 0xE7, 0x44 } };

lib/Runtime/Library/EngineInterfaceObjectBuiltIns.h

@@ -58,6 +58,7 @@ BuiltInRaiseException1(TypeError, This_NullOrUndefined)
 BuiltInRaiseException1(TypeError, NotAConstructor)
 BuiltInRaiseException1(TypeError, ObjectIsNonExtensible)
 BuiltInRaiseException1(TypeError, LengthIsTooBig)
+BuiltInRaiseException1(TypeError, NonObjectFromIterable)
 BuiltInRaiseException2(TypeError, NeedObjectOfType)
 BuiltInRaiseException1(RangeError, InvalidCurrencyCode)
 BuiltInRaiseException(TypeError, MissingCurrencyCode)

lib/Runtime/Library/InJavascript/Intl.js.bc.32b.h

@@ -3651,6 +3651,18 @@ namespace Js
             propertyCount++;
         }
 
+        if (scriptContext->GetConfig()->IsES7ValuesEntriesEnabled())
+        {
+            propertyCount += 2;
+        }
+
+#ifdef ENABLE_JS_BUILTINS
+        if (scriptContext->IsJsBuiltInEnabled())
+        {
+            propertyCount++;
+        }
+#endif
+
         typeHandler->Convert(objectConstructor, mode, propertyCount);
 
         library->AddMember(objectConstructor, PropertyIds::length, TaggedInt::ToVarUnchecked(1), PropertyConfigurable);
@@ -3707,6 +3719,13 @@ namespace Js
                 library->AddFunctionToLibraryObject(objectConstructor, PropertyIds::entries, &JavascriptObject::EntryInfo::Entries, 1));
         }
 
+#ifdef ENABLE_JS_BUILTINS
+        if (scriptContext->IsJsBuiltInEnabled())
+        {
+            library->EnsureBuiltInEngineIsReady();
+        }
+#endif
+
         objectConstructor->SetHasNoEnumerableProperties(true);
 
         return true;

lib/Runtime/Library/InJavascript/Intl.js.bc.64b.h

@@ -17,6 +17,7 @@
         ArrayFlat: { className: "Array", methodName: "flat", argumentsCount: 0, forceInline: true /*optional*/ },
         ArrayFlatMap: { className: "Array", methodName: "flatMap", argumentsCount: 1, forceInline: true /*optional*/ },
         ArrayForEach: { className: "Array", methodName: "forEach", argumentsCount: 1, forceInline: true /*optional*/ },
+        ObjectFromEntries: { className: "Object", staticMethod: true, methodName: "fromEntries", argumentsCount: 1, forceInline: true /*optional*/ },
     };
 
     var setPrototype = platform.builtInSetPrototype;
@@ -39,10 +40,13 @@
     __chakraLibrary.ArrayIterator.prototype = CreateObject(iteratorPrototype);
     __chakraLibrary.raiseNeedObjectOfType = platform.raiseNeedObjectOfType;
     __chakraLibrary.raiseThis_NullOrUndefined = platform.raiseThis_NullOrUndefined;
+    __chakraLibrary.raiseNeedObject = platform.raiseNeedObject;
+    __chakraLibrary.raiseNonObjectFromIterable = platform.raiseNonObjectFromIterable;
     __chakraLibrary.raiseLengthIsTooBig = platform.raiseLengthIsTooBig;
     __chakraLibrary.raiseFunctionArgument_NeedFunction = platform.raiseFunctionArgument_NeedFunction;
     __chakraLibrary.callInstanceFunc = platform.builtInCallInstanceFunction;
     __chakraLibrary.functionBind = platform.builtInJavascriptFunctionEntryBind;
+    __chakraLibrary.objectDefineProperty = _objectDefineProperty;
 
     _objectDefineProperty(__chakraLibrary.ArrayIterator.prototype, 'next',
         // Object's getter and setter can get overriden on the prototype, in that case while setting the value attributes, we will end up with TypeError
@@ -440,4 +444,32 @@
 
         return undefined;
     });
+
+    platform.registerFunction(FunctionsEnum.ObjectFromEntries, function (iterable) {
+        // #sec-object.fromentries
+        "use strict";
+        if (iterable === null || iterable === undefined) {
+            __chakraLibrary.raiseNeedObject("Object.fromEntries");
+        }
+
+        const o = {};
+        const propDescriptor = {
+            enumerable : true,
+            configurable : true,
+            writable : true,
+            value : undefined
+        };
+
+        let key;
+        for (const entry of iterable) {
+            if (typeof entry !== "object" || entry === null) {
+                __chakraLibrary.raiseNonObjectFromIterable("Object.fromEntries");
+            }
+
+            key = entry[0];
+            propDescriptor.value = entry[1];
+            __chakraLibrary.objectDefineProperty(o, key, propDescriptor);
+        }
+        return o;
+    });
 });