From 7c96998e80758042ed7f6dad80c761ebdd37994d Mon Sep 17 00:00:00 2001 From: setht Date: Fri, 10 Mar 2017 09:03:44 -0800 Subject: [PATCH 1/4] moved sret creation within the symbols iteration having sret outside of the loop was causing the sret output data to be overwritten to the last symbol in the array --- R/strategy.R | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/R/strategy.R b/R/strategy.R index 72651f7..1a49601 100644 --- a/R/strategy.R +++ b/R/strategy.R @@ -139,9 +139,9 @@ applyStrategy <- function(strategy, if(isTRUE(debug)) ret[[portfolio]]<-list() # this is slot [[i]] which we will use later pobj<-.getPortfolio(portfolio) symbols<- ls(pobj$symbols) - sret<-new.env(hash=TRUE) - + for (symbol in symbols){ + sret<-new.env(hash=TRUE) if(isTRUE(load.mktdata)){ if(isTRUE(initBySymbol)) initSymbol(strategy, symbol, ... = ...) mktdata <- get(symbol) From f22e632c28bab878a6e0369de179dae183783470 Mon Sep 17 00:00:00 2001 From: setht Date: Fri, 10 Mar 2017 09:04:22 -0800 Subject: [PATCH 2/4] Update strategy.R --- R/strategy.R | 2 ++ 1 file changed, 2 insertions(+) diff --git a/R/strategy.R b/R/strategy.R index 1a49601..e347258 100644 --- a/R/strategy.R +++ b/R/strategy.R @@ -141,7 +141,9 @@ applyStrategy <- function(strategy, symbols<- ls(pobj$symbols) for (symbol in symbols){ + sret<-new.env(hash=TRUE) + if(isTRUE(load.mktdata)){ if(isTRUE(initBySymbol)) initSymbol(strategy, symbol, ... = ...) mktdata <- get(symbol) From ccf60a74e2e96d190250c2033fca7e89f7337751 Mon Sep 17 00:00:00 2001 From: setht Date: Fri, 10 Mar 2017 09:16:38 -0800 Subject: [PATCH 3/4] Update strategy.R --- R/strategy.R | 2 -- 1 file changed, 2 deletions(-) diff --git a/R/strategy.R b/R/strategy.R index e347258..1a49601 100644 --- a/R/strategy.R +++ b/R/strategy.R @@ -141,9 +141,7 @@ applyStrategy <- function(strategy, symbols<- ls(pobj$symbols) for (symbol in symbols){ - sret<-new.env(hash=TRUE) - if(isTRUE(load.mktdata)){ if(isTRUE(initBySymbol)) initSymbol(strategy, symbol, ... = ...) mktdata <- get(symbol) From b2dede8e72f71935bb6de9de6d76cafffec48d50 Mon Sep 17 00:00:00 2001 From: setht Date: Fri, 10 Mar 2017 09:17:07 -0800 Subject: [PATCH 4/4] Update strategy.R --- R/strategy.R | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/R/strategy.R b/R/strategy.R index 1a49601..6f8f902 100644 --- a/R/strategy.R +++ b/R/strategy.R @@ -138,8 +138,7 @@ applyStrategy <- function(strategy, if(isTRUE(debug)) ret[[portfolio]]<-list() # this is slot [[i]] which we will use later pobj<-.getPortfolio(portfolio) - symbols<- ls(pobj$symbols) - + symbols<- ls(pobj$symbols) for (symbol in symbols){ sret<-new.env(hash=TRUE) if(isTRUE(load.mktdata)){