Test StringSerializableRegistry.remove

Author: bogdandm

rest_client_gen/dynamic_typing/string_serializable.py

@@ -79,7 +79,7 @@ def remove(self, cls: type):
         """
         self.types.remove(cls)
         for base, replace in list(self.replaces):
-            if replace is cls:
+            if replace is cls or base is cls:
                 self.replaces.remove((base, replace))
 
     def resolve(self, *types: T_StringSerializable) -> Collection[T_StringSerializable]:

test/test_dynamic_typing/test_string_serializable_registry.py

@@ -1,6 +1,9 @@
 import pytest
 
-from rest_client_gen.dynamic_typing.string_serializable import StringSerializable, StringSerializableRegistry
+from rest_client_gen.dynamic_typing import IsoTimeString
+from rest_client_gen.dynamic_typing.string_serializable import (FloatString, IntString, StringSerializable,
+                                                                StringSerializableRegistry)
+from rest_client_gen.generator import MetadataGenerator
 
 r = StringSerializableRegistry()
 
@@ -54,7 +57,30 @@ class Y(StringSerializable):
     pytest.param((X, B), {B, X}),
 ]
 
+
 @pytest.mark.parametrize("value,expected", test_data)
 def test_string_serializable_registry(value, expected):
     result = r.resolve(*value)
-    assert result == expected
+    assert result == expected
+
+
+r2 = StringSerializableRegistry()
+gen = MetadataGenerator(r2)
+
+r2.add(cls=IsoTimeString)
+r2.add(cls=IntString)
+r2.add(replace_types=(IntString,), cls=FloatString)
+
+
+@pytest.mark.xfail()
+def test_without_remove():
+    assert gen._detect_type("12") == IntString
+
+
+r2.remove(IsoTimeString)
+r2.add(cls=IsoTimeString)
+
+
+def test_remove():
+    assert gen._detect_type("12") == IntString
+    assert gen._detect_type("12:14") == IsoTimeString