Skip to content

Commit 5f0030d

Browse files
committed
bring back images for contributing
1 parent 42805c6 commit 5f0030d

16 files changed

+10
-11
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ tmp*
55
*.zip*
66

77
*.jpg
8-
*.png
98
*.ps
109

1110
*.log

CONTRIBUTING.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -307,14 +307,14 @@ Upon opening the pull request we see a detailed description of what this pull
307307
request is seeking to address. Descriptions are important for reviewers and the
308308
community to gain context into what the pull request is achieving.
309309

310-
![BIDS-pr](images/BIDS_pr.png "BIDS_pr")
310+
![BIDS-pr](docs/commenting_images/BIDS_pr.png "BIDS_pr")
311311

312312
### Generally commenting on a pull request
313313

314314
At the bottom of the pull request page, a comment box is provided for general
315315
comments and questions.
316316

317-
![BIDS-comment](images/BIDS_comment.png "BIDS-comment")
317+
![BIDS-comment](docs/commenting_images/BIDS_comment.png "BIDS-comment")
318318

319319
### Specific comments on a pull request
320320

@@ -325,27 +325,27 @@ before each removed line. To comment on a specific line, hover over it, and
325325
click the blue plus sign (pictured below). Multiple lines can be selected by
326326
clicking and dragging the plus sign.
327327

328-
![BIDS-specific-comment](images/BIDS_file_comment.png "BIDS-specific-comment")
328+
![BIDS-specific-comment](docs/commenting_images/BIDS_file_comment.png "BIDS-specific-comment")
329329

330330
#### Suggesting text
331331

332332
Comments on lines can contain "suggestions", which allow you to propose specific
333333
wording for consideration. To make a suggestion, click the plus/minus (±) icon
334334
in the comment box (pictured below).
335335

336-
![BIDS-suggest-box](images/BIDS_suggest.png "BIDS-suggest")
336+
![BIDS-suggest-box](docs/commenting_images/BIDS_suggest.png "BIDS-suggest")
337337

338338
Once the button is clicked the highlighted text will be copied into the comment
339339
box and formatted as a
340340
[Markdown code block](https://help.github.com/en/github/writing-on-github/creating-and-highlighting-code-blocks).
341341

342-
![BIDS-suggest-text](images/BIDS_suggest_text.png "BIDS-suggest-box")
342+
![BIDS-suggest-text](docs/commenting_images/BIDS_suggest_text.png "BIDS-suggest-box")
343343

344344
The "Preview" tab in the comment box will show your suggestion as it will be
345345
rendered. The "Suggested change" box will highlight the differences between the
346346
original text and your suggestion.
347347

348-
![BIDS-suggest-change](images/BIDS_suggest_change.png "BIDS-suggest-change")
348+
![BIDS-suggest-change](docs/commenting_images/BIDS_suggest_change.png "BIDS-suggest-change")
349349

350350
A comment may be submitted on its own by clicking "Add single comment". Several
351351
comments may be grouped by clicking "Start a review". As more comments are
@@ -364,26 +364,26 @@ their contribution.
364364
To do this, you must click on the `Files changed` tab at the top of the page of
365365
a pull request.
366366

367-
![BIDS_pr_files_changed](images/BIDS_pr_files_changed.png "BIDS_pr_files_changed")
367+
![BIDS_pr_files_changed](docs/commenting_images/BIDS_pr_files_changed.png "BIDS_pr_files_changed")
368368

369369
From there you can browse the different files changed and the 'diff' for each of
370370
them (what line was changed and what the change consist of). You can also see
371371
comments and directly change suggestions made by reviewers.
372372

373373
You can add each suggestion one by one or group them together in a batch.
374374

375-
![BIDS_pr_accept_comment](images/BIDS_pr_accept_comment.png "BIDS_pr_accept_comment")
375+
![BIDS_pr_accept_comment](docs/commenting_images/BIDS_pr_accept_comment.png "BIDS_pr_accept_comment")
376376

377377
If you decide to batch the suggestions to add several of them at once, you must
378378
scroll back to the top of the 'Files changed' page and the `commit suggestions`
379379
button will let you add all those suggestions as a single commit.
380380

381-
![BIDS_pr_commit_batch](images/BIDS_pr_commit_batch.png "BIDS_pr_commit_batch")
381+
![BIDS_pr_commit_batch](docs/commenting_images/BIDS_pr_commit_batch.png "BIDS_pr_commit_batch")
382382

383383
Once those suggestions are committed the commit information should mention the
384384
reviewer as a co-author.
385385

386-
![BIDS_pr_reviewer_credit](images/BIDS_pr_reviewer_credit.png "BIDS_pr_reviewer_credit")
386+
![BIDS_pr_reviewer_credit](docs/commenting_images/BIDS_pr_reviewer_credit.png "BIDS_pr_reviewer_credit")
387387

388388
## How the decision to merge a pull request is made?
389389

225 KB
Loading
90.9 KB
Loading
40.1 KB
Loading
284 KB
Loading

docs/commenting_images/BIDS_pr.png

460 KB
Loading
35.4 KB
Loading
31.9 KB
Loading
242 KB
Loading

0 commit comments

Comments
 (0)