Fix clj-kondo linting errors and clean up unused imports

Bruce Hauman · Bruce Hauman · commit 66213a740a5b · 2025-11-13T12:20:46.000-06:00
- Fix 2 critical arity errors in file_edit/pipeline.clj
- Add missing namespace requires in test files
- Remove unused namespace requires (10 files)
- Clean up unused Java imports in langchain files (19 imports)
- Replace unused exception bindings with underscore

Reduced warnings from 285 to 230. All tests passing.
diff --git a/src/clojure_mcp/agent/general_agent.clj b/src/clojure_mcp/agent/general_agent.clj
@@ -5,7 +5,6 @@
             [clojure.tools.logging :as log]
             [clojure.java.io :as io]
             [clojure-mcp.agent.langchain :as chain]
-            [clojure-mcp.config :as config]
             [clojure-mcp.tools.project.core :as project-core]
             [clojure-mcp.tools :as tools]
             [clojure-mcp.utils.file :as file-utils])
diff --git a/src/clojure_mcp/agent/langchain.clj b/src/clojure_mcp/agent/langchain.clj
@@ -7,34 +7,26 @@
    [clojure.pprint])
   (:import
    ;; LangChain4j Core and Service classes
-   [dev.langchain4j.service AiServices MemoryId]
+   [dev.langchain4j.service AiServices]
    [dev.langchain4j.agent.tool ToolSpecification #_ToolParameter]
-   [dev.langchain4j.service.tool ToolExecutor ToolExecution]
-   [dev.langchain4j.service TokenStream]
-   [dev.langchain4j.data.message SystemMessage UserMessage TextContent]
+   [dev.langchain4j.service.tool ToolExecutor]
+   [dev.langchain4j.data.message SystemMessage UserMessage]
    [dev.langchain4j.agent.tool ToolExecutionRequest]
-   [dev.langchain4j.model.chat.request.json JsonObjectSchema]
-   [dev.langchain4j.memory ChatMemory]
    [dev.langchain4j.memory.chat MessageWindowChatMemory]
-   [dev.langchain4j.model.chat.request ChatRequest ToolChoice]
+   [dev.langchain4j.model.chat.request ChatRequest]
 
    ;; LangChain4j Model classes (using Anthropic as an example)
    [dev.langchain4j.model.anthropic
     AnthropicChatModel
-    AnthropicStreamingChatModel
     AnthropicChatModelName]
    [dev.langchain4j.model.googleai
     GoogleAiGeminiChatModel
     GeminiThinkingConfig]
-   [java.util.function Consumer Function]
+   [java.util.function Function]
 
    [dev.langchain4j.model.openai
     OpenAiChatModel
-    OpenAiChatRequestParameters
-    OpenAiChatModelName]
-
-   ;; Java Time API
-   [java.time LocalTime LocalDate ZoneId]))
+    OpenAiChatRequestParameters]))
 
 (def default-max-memory 100)
 
diff --git a/src/clojure_mcp/agent/langchain/chat_listener.clj b/src/clojure_mcp/agent/langchain/chat_listener.clj
@@ -111,22 +111,22 @@
       (when on-request
         (try
           (on-request (chat-request-context->edn request-context))
-          (catch Exception e
-            #_(log/error e "Error in on-request handler")))))
+          (catch Exception _
+            #_(log/error _ "Error in on-request handler")))))
 
     (onResponse [_ response-context]
       (when on-response
         (try
           (on-response (chat-response-context->edn response-context))
-          (catch Exception e
-            #_(log/error e "Error in on-response handler")))))
+          (catch Exception _
+            #_(log/error _ "Error in on-response handler")))))
 
     (onError [_ error-context]
       (when on-error
         (try
           (on-error (chat-error-context->edn error-context))
-          (catch Exception e
-            #_(log/error e "Error in on-error handler")))))))
+          (catch Exception _
+            #_(log/error _ "Error in on-error handler")))))))
 
 (defn logging-listener
   "Create a listener that logs all events at specified levels.
diff --git a/src/clojure_mcp/agent/langchain/message_conv.clj b/src/clojure_mcp/agent/langchain/message_conv.clj
@@ -12,10 +12,6 @@
    [clojure.data.json :as json])
   (:import
    [dev.langchain4j.data.message
-    UserMessage
-    AiMessage
-    SystemMessage
-    ToolExecutionResultMessage
     ChatMessageSerializer
     ChatMessageDeserializer]))
 
diff --git a/src/clojure_mcp/agent/langchain/model.clj b/src/clojure_mcp/agent/langchain/model.clj
@@ -1,6 +1,5 @@
 (ns clojure-mcp.agent.langchain.model
   (:require
-   [clojure.string :as string]
    [clojure-mcp.config.schema :as schema]
    [clojure-mcp.config :as config]
    [clojure.tools.logging :as log])
diff --git a/src/clojure_mcp/agent/langchain/schema.clj b/src/clojure_mcp/agent/langchain/schema.clj
@@ -8,11 +8,9 @@
     JsonBooleanSchema
     JsonEnumSchema
     JsonIntegerSchema
-    JsonNullSchema
     JsonNumberSchema
     JsonObjectSchema
-    JsonStringSchema
-    JsonSchemaElement]))
+    JsonStringSchema]))
 
 (defmulti edn->sch
   (fn [{:keys [type enum] :as json-edn}]
diff --git a/src/clojure_mcp/config.clj b/src/clojure_mcp/config.clj
@@ -1,8 +1,6 @@
 (ns clojure-mcp.config
   (:require
    [clojure.java.io :as io]
-   [clojure.string :as str]
-   [clojure-mcp.dialects :as dialects]
    [clojure-mcp.config.schema :as schema]
    [clojure-mcp.utils.file :as file-utils]
    [clojure.edn :as edn]
@@ -14,7 +12,7 @@
       (if (.isAbsolute f)
         (.getCanonicalPath f)
         (.getCanonicalPath (io/file dir path))))
-    (catch Exception e
+    (catch Exception _
       (log/warn "Bad file paths " (pr-str [dir path]))
       nil)))
 
@@ -86,7 +84,7 @@
                            :config config
                            :file-path canonical-path})))))))
 
-(defn process-config [{:keys [allowed-directories write-file-guard cljfmt bash-over-nrepl nrepl-env-type] :as config} user-dir]
+(defn process-config [{:keys [allowed-directories write-file-guard] :as config} user-dir]
   (let [ud (io/file user-dir)]
     (assert (and (.isAbsolute ud) (.isDirectory ud)))
     (when (some? write-file-guard)
diff --git a/src/clojure_mcp/core.clj b/src/clojure_mcp/core.clj
@@ -1,9 +1,7 @@
 (ns clojure-mcp.core
   (:require [clojure.data.json :as json]
-            [clojure.edn :as edn]
             [clojure.java.io :as io]
             [clojure.spec.alpha :as s]
-            [clojure.string :as str]
             [clojure.tools.logging :as log]
             [clojure-mcp.nrepl :as nrepl]
             [clojure-mcp.config :as config]
diff --git a/src/clojure_mcp/main.clj b/src/clojure_mcp/main.clj
@@ -1,14 +1,7 @@
 (ns clojure-mcp.main
-  (:require [clojure.edn :as edn]
-            [clojure.java.io :as io]
-            [clojure.string :as str]
-            [clojure.tools.logging :as log]
-            [clojure-mcp.core :as core]
-            [clojure-mcp.nrepl :as nrepl]
+  (:require [clojure-mcp.core :as core]
             [clojure-mcp.prompts :as prompts]
-            [clojure-mcp.tools.project.core :as project]
             [clojure-mcp.resources :as resources]
-            [clojure-mcp.config :as config]
             [clojure-mcp.tools :as tools]))
 
 ;; Delegate to resources namespace
diff --git a/src/clojure_mcp/nrepl.clj b/src/clojure_mcp/nrepl.clj
@@ -1,6 +1,5 @@
 (ns clojure-mcp.nrepl
   (:require
-   [clojure.string :as string]
    [clojure.main]
    [nrepl.core :as nrepl]
    [nrepl.misc :as nrepl.misc]
diff --git a/src/clojure_mcp/prompt_cli.clj b/src/clojure_mcp/prompt_cli.clj
@@ -4,13 +4,11 @@
             [clojure.edn :as edn]
             [clojure.java.io :as io]
             [clojure.string :as str]
-            [clojure.tools.logging :as log]
             [clojure.pprint :as pp]
             [clojure.data.json :as json]
             [clojure-mcp.nrepl :as nrepl]
             [clojure-mcp.config :as config]
             [clojure-mcp.dialects :as dialects]
-            [clojure-mcp.core :as core]
             [clojure-mcp.tools.agent-tool-builder.core :as agent-core]
             [clojure-mcp.tools.agent-tool-builder.default-agents :as default-agents]
             [clojure-mcp.agent.general-agent :as general-agent]
diff --git a/src/clojure_mcp/prompts.clj b/src/clojure_mcp/prompts.clj
@@ -1,6 +1,7 @@
 (ns clojure-mcp.prompts
   "Prompt definitions for the MCP server"
-  (:require [clojure.string :as str]
+  (:require [clojure.edn :as edn]
+            [clojure.string :as str]
             [clojure.java.io :as io]
             [pogonos.core :as pg]
             [clojure-mcp.config :as config]
@@ -169,7 +170,7 @@ After doing this provide a very brief (8 lines) summary of where we are and then
                   (try
                     ;; Load the file
                     (if (.exists file)
-                      (let [data (clojure.edn/read-string (file-utils/slurp-utf8 file))
+                      (let [data (edn/read-string (file-utils/slurp-utf8 file))
                             ;; Update the scratch pad atom
                             _ (scratch-pad/update-scratch-pad! nrepl-client-atom (constantly data))
                             ;; Get shallow inspect of the data
diff --git a/src/clojure_mcp/resources.clj b/src/clojure_mcp/resources.clj
@@ -1,9 +1,6 @@
 (ns clojure-mcp.resources
   (:require [clojure.java.io :as io]
             [clojure.string :as str]
-            [clojure.data.json :as json]
-            [clojure.edn :as edn]
-            [clojure-mcp.nrepl :as mcp-nrepl]
             [clojure-mcp.config :as config]
             [clojure-mcp.file-content :as file-content]
             [clojure-mcp.tools.project.core :as project]
diff --git a/src/clojure_mcp/sexp/match.clj b/src/clojure_mcp/sexp/match.clj
@@ -1,6 +1,5 @@
 (ns clojure-mcp.sexp.match
   (:require [rewrite-clj.zip :as z]
-            [rewrite-clj.node :as n]
             [rewrite-clj.parser :as p]))
 
 (defn match-sexpr
diff --git a/src/clojure_mcp/tools/file_edit/pipeline.clj b/src/clojure_mcp/tools/file_edit/pipeline.clj
@@ -174,11 +174,11 @@
   (format-result result)
 
   ;; Test the pipeline with error (non-unique match)
-  (def error-result (file-edit-pipeline test-file "Line" "EDITED Line" {}))
+  (def error-result (file-edit-pipeline test-file "Line" "EDITED Line" nil {}))
   (format-result error-result)
 
   ;; Test the pipeline with error (empty old_string)
-  (def empty-string-result (file-edit-pipeline test-file "" "New content" {}))
+  (def empty-string-result (file-edit-pipeline test-file "" "New content" nil {}))
   (format-result empty-string-result)
 
   ;; Clean up
diff --git a/test/clojure_mcp/agent/general_agent_test.clj b/test/clojure_mcp/agent/general_agent_test.clj
@@ -1,5 +1,6 @@
 (ns clojure-mcp.agent.general-agent-test
   (:require [clojure.test :refer :all]
+            [clojure.string :as str]
             [clojure-mcp.agent.general-agent :as general-agent]
             [clojure-mcp.config :as config]
             [clojure-mcp.agent.langchain :as chain]
@@ -15,7 +16,7 @@
           nrepl-client-atom (atom {})
           context (general-agent/build-context-strings nrepl-client-atom (.getPath temp-dir) true)]
       (is (vector? context))
-      (is (some #(clojure.string/includes? % "Test project summary") context))
+      (is (some #(str/includes? % "Test project summary") context))
       ;; Cleanup
       (.delete project-summary)
       (.delete temp-dir)))
diff --git a/test/clojure_mcp/tools/bash/session_test.clj b/test/clojure_mcp/tools/bash/session_test.clj
@@ -3,6 +3,7 @@
   (:require [clojure.test :refer :all]
             [clojure-mcp.tools.bash.tool :as bash-tool]
             [clojure-mcp.tools.bash.core :as bash-core]
+            [clojure-mcp.tools.eval.core :as eval-core]
             [clojure-mcp.nrepl :as nrepl]
             [clojure-mcp.config :as config]
             [clojure-mcp.tool-system :as tool-system]))
diff --git a/test/clojure_mcp/tools/directory_tree/tool_test.clj b/test/clojure_mcp/tools/directory_tree/tool_test.clj
@@ -1,6 +1,8 @@
 (ns clojure-mcp.tools.directory-tree.tool-test
   (:require [clojure.test :refer :all]
             [clojure-mcp.tools.directory-tree.tool :as sut]
+            [clojure-mcp.tools.directory-tree.core :as directory-tree-core]
+            [clojure-mcp.utils.valid-paths :as valid-paths]
             [clojure-mcp.config :as config] ; Added config require
             [clojure-mcp.tool-system :as tool-system]))
 
diff --git a/test/clojure_mcp/tools/grep/tool_test.clj b/test/clojure_mcp/tools/grep/tool_test.clj
@@ -1,6 +1,8 @@
 (ns clojure-mcp.tools.grep.tool-test
   (:require [clojure.test :refer :all]
             [clojure-mcp.tools.grep.tool :as sut]
+            [clojure-mcp.tools.grep.core :as grep-core]
+            [clojure-mcp.utils.valid-paths :as valid-paths]
             [clojure-mcp.tool-system :as tool-system]
             [clojure-mcp.config :as config] ; Added config require
             [clojure.string :as str]
diff --git a/test/clojure_mcp/tools/scratch_pad/core_test.clj b/test/clojure_mcp/tools/scratch_pad/core_test.clj
@@ -1,5 +1,6 @@
 (ns clojure-mcp.tools.scratch-pad.core-test
   (:require [clojure.test :refer :all]
+            [clojure.string :as str]
             [clojure-mcp.tools.scratch-pad.core :as core]))
 
 (deftest test-execute-set-path
@@ -79,7 +80,7 @@
     (let [result (core/execute-inspect {} 5 nil)
           tree-output (get-in result [:result :tree])]
       ;; Account for possible newline
-      (is (= "{}" (clojure.string/trim tree-output))))))
+      (is (= "{}" (str/trim tree-output))))))
 
 (deftest test-inspect-data
   (testing "Inspect data generation"
diff --git a/test/clojure_mcp/tools/scratch_pad/smart_path_test.clj b/test/clojure_mcp/tools/scratch_pad/smart_path_test.clj
@@ -1,5 +1,6 @@
 (ns clojure-mcp.tools.scratch-pad.smart-path-test
   (:require [clojure.test :refer [deftest testing is]]
+            [clojure.string :as str]
             [clojure-mcp.tools.scratch-pad.smart-path :as sp]))
 
 (deftest test-parse-positive-int
@@ -58,7 +59,7 @@
     (is (= {"count" 6}
            (sp/smart-update-in {"count" 5} ["count"] inc)))
     (is (= {"items" ["A" "b"]}
-           (sp/smart-update-in {"items" ["a" "b"]} ["items" "0"] clojure.string/upper-case)))))
+           (sp/smart-update-in {"items" ["a" "b"]} ["items" "0"] str/upper-case)))))
 
 (deftest test-smart-dissoc-in
   (testing "dissoc from vector"
