Fix clj-kondo warnings: remove unused imports and bindings

- Remove unused imports from core namespaces
- Fix unused bindings by replacing with underscore prefix
- Move type hints to arg vectors
- Replace (not (empty? x)) with (seq x)
- Fix inline def in tests
- Simplify redundant str calls

Reduces warnings from 226 to 169 (25% reduction)
All tests passing: 295 tests, 2085 assertions

Author: Bruce Hauman

src/clojure_mcp/agent/general_agent.clj

@@ -167,7 +167,7 @@ Please use it to inform you as to which files should be investigated.\n=========
      :system-message - The system prompt
      :stateless? - Whether memory clears on each chat
      :memory-size - The configured memory size (for reset logic)"
-  [{:keys [system-prompt context tools memory model memory-size]}]
+  [{:keys [system-prompt context tools model memory-size]}]
   (try
     (when-not model
       (throw (ex-info "Model is required" {:missing :model})))
@@ -176,7 +176,7 @@ Please use it to inform you as to which files should be investigated.\n=========
       (throw (ex-info "System prompt is required" {:missing :system-prompt})))
 
     (let [;; Use new memory-size logic
-          {:keys [memory stateless?] :as memory-config} (create-memory-for-config memory-size)
+          {:keys [memory stateless?]} (create-memory-for-config memory-size)
           ;; Get the actual memory size for reset logic
           actual-memory-size (if stateless?
                                DEFAULT-STATELESS-BUFFER

src/clojure_mcp/agent/langchain.clj

@@ -11,7 +11,6 @@
    [dev.langchain4j.agent.tool ToolSpecification #_ToolParameter]
    [dev.langchain4j.service.tool ToolExecutor]
    [dev.langchain4j.data.message SystemMessage UserMessage]
-   [dev.langchain4j.agent.tool ToolExecutionRequest]
    [dev.langchain4j.memory.chat MessageWindowChatMemory]
    [dev.langchain4j.model.chat.request ChatRequest]
 
@@ -137,7 +136,7 @@
 
 (defn registration-map->tool-executor [{:keys [tool-fn]}]
   (reify ToolExecutor
-    (execute [_this request memory-id]
+    (execute [_this request _memory-id]
       (let [tool-name (.name request)
             arg-str (.arguments request)]
         (if-let [arg-result (is-well-formed-json? arg-str)]
@@ -178,7 +177,7 @@
                    registration-map->tool-executor)
              registration-maps)))
 
-(defn chat-request [message & {:keys [system-message tools require-tool-choice]}]
+(defn chat-request [message & {:keys [system-message tools]}]
   ;; ChatResponse response = model.chat(request);
   ;;AiMessage aiMessage = response.aiMessage();
   (cond-> (ChatRequest/builder)
@@ -199,7 +198,7 @@
       (.chatModel model)
       (.systemMessageProvider
        (reify Function
-         (apply [this mem-id]
+         (apply [_this _mem-id]
            system-message)))
       (cond->
        tools (.tools (convert-tools tools)))

src/clojure_mcp/core.clj

@@ -10,29 +10,24 @@
             [clojure-mcp.nrepl-launcher :as nrepl-launcher])
   (:import [io.modelcontextprotocol.server.transport
             StdioServerTransportProvider]
-           [io.modelcontextprotocol.server McpServer McpServerFeatures
+           [io.modelcontextprotocol.server McpServer
             McpServerFeatures$AsyncToolSpecification
-            McpServerFeatures$AsyncResourceSpecification]
+            McpServerFeatures$AsyncResourceSpecification
+            McpServerFeatures$AsyncPromptSpecification]
            [io.modelcontextprotocol.spec
             McpSchema$ServerCapabilities
             McpSchema$Tool
             McpSchema$CallToolResult
             McpSchema$TextContent
-            McpSchema$ImageContent
             McpSchema$Prompt
             McpSchema$PromptArgument
             McpSchema$GetPromptRequest
             McpSchema$GetPromptResult
             McpSchema$PromptMessage
             McpSchema$Role
-            McpSchema$LoggingLevel
             McpSchema$Resource
-            McpSchema$ReadResourceResult
             McpSchema$TextResourceContents
-            McpSchema$ResourceContents]
-           [io.modelcontextprotocol.server McpServer McpServerFeatures
-            McpServerFeatures$AsyncToolSpecification
-            McpServerFeatures$AsyncPromptSpecification]
+            McpSchema$ReadResourceResult]
            [reactor.core.publisher Mono]
            [io.modelcontextprotocol.json McpJsonMapper]))
 
@@ -47,7 +42,7 @@
   (fn [exchange arguments]
     (Mono/create
      (reify java.util.function.Consumer
-       (accept [this sink]
+       (accept [_this sink]
          (callback-fn
           exchange
           arguments
@@ -61,7 +56,7 @@
     (file-content/file-response->file-content result)
     :else (McpSchema$TextContent. " ")))
 
-(defn ^McpSchema$CallToolResult adapt-results [list-str error?]
+(defn adapt-results ^McpSchema$CallToolResult [list-str error?]
   (McpSchema$CallToolResult. (vec (keep adapt-result list-str)) error?))
 
 (defn create-async-tool
@@ -95,13 +90,14 @@
     (McpServerFeatures$AsyncToolSpecification.
      mcp-tool
      (reify java.util.function.BiFunction
-       (apply [this exchange arguments]
+       (apply [_this exchange arguments]
          (log/debug (str "Args from MCP: " (pr-str arguments)))
          (mono-fn exchange arguments))))))
 
-(defn ^McpSchema$GetPromptResult adapt-prompt-result
+(defn adapt-prompt-result
   "Adapts a Clojure prompt result map into an McpSchema$GetPromptResult.
    Expects a map like {:description \"...\" :messages [{:role :user :content \"...\"}]}"
+  ^McpSchema$GetPromptResult
   [{:keys [description messages]}]
   (let [mcp-messages (mapv (fn [{:keys [role content]}]
                              (McpSchema$PromptMessage.
@@ -144,7 +140,7 @@
     (McpServerFeatures$AsyncPromptSpecification.
      mcp-prompt
      (reify java.util.function.BiFunction
-       (apply [this exchange request]
+       (apply [_this exchange request]
          (mono-fn exchange request))))))
 
 (defn add-tool
@@ -184,7 +180,7 @@
     (McpServerFeatures$AsyncResourceSpecification.
      resource
      (reify java.util.function.BiFunction
-       (apply [this exchange request]
+       (apply [_this exchange request]
          (mono-fn exchange request))))))
 
 (defn add-resource
@@ -245,7 +241,7 @@
       (if (= ::config/schema-error (-> e ex-data :type))
         (let [{:keys [errors file-path]} (ex-data e)]
           (binding [*out* *err*]
-            (println (str "\n❌ Configuration validation failed!\n"))
+            (println "\n❌ Configuration validation failed!\n")
             (when file-path
               (println (str "File: " file-path "\n")))
             (println "Errors found:")

src/clojure_mcp/nrepl.clj

@@ -5,9 +5,7 @@
    [nrepl.misc :as nrepl.misc]
    [nrepl.transport]
    [clojure.tools.logging :as log]
-   [clojure.edn])
-  (:import
-   [java.util.concurrent LinkedBlockingQueue TimeUnit]))
+   [clojure.edn]))
 
 ;; callback system
 (defn add-callback! [{:keys [::state]} id f]
@@ -22,7 +20,7 @@
 (defn remove-current-eval-id! [{:keys [::state]}]
   (swap! state dissoc :current-eval-id))
 
-(defn dispatch-response! [{:keys [::state] :as service} msg]
+(defn dispatch-response! [{:keys [::state]} msg]
   (doseq [f (vals (get @state :id-callbacks))]
     (f msg)))
 
@@ -95,12 +93,12 @@
   (get @state :ns-session))
 
 (defn current-ns
-  ([{:keys [::state] :as service} session]
+  ([{:keys [::state]} session]
    (get-in @state [:current-ns session]))
-  ([{:keys [::state] :as service} session new-ns]
+  ([{:keys [::state]} session new-ns]
    (swap! state assoc-in [:current-ns session] new-ns)))
 
-(defn new-message [{:keys [::state] :as service} msg]
+(defn new-message [service msg]
   (merge
    {:session (eval-session service)
     :id (new-id)}
@@ -115,7 +113,7 @@
 (def truncation-length 10000) ;; 20000 roughly 250 lines
 
 (defn eval-code-msg
-  [{:keys [::state] :as service} code-str msg' k]
+  [service code-str msg' k]
   (let [msg (merge
              msg'
              {:op "eval"
@@ -154,7 +152,7 @@
        (new-message service {:op "interrupt" :interrupt-id current-eval-id})
        identity))))
 
-(defn lookup [{:keys [::state] :as service} symbol]
+(defn lookup [service symbol]
   (let [prom (promise)]
     (send-msg! service
                (new-tool-message service {:op "lookup" :sym symbol})
@@ -166,7 +164,7 @@
                                             (update :arglists clojure.edn/read-string))))))
     (deref prom 400 nil)))
 
-(defn completions [{:keys [::state] :as service} prefix]
+(defn completions [service prefix]
   (let [prom (promise)]
     (send-msg! service
                (new-tool-message service {:op "completions" :prefix prefix})
@@ -182,7 +180,7 @@
                     (value #(deliver prom %))))
     (deref prom 400 nil)))
 
-(defn ls-middleware [{:keys [::state] :as service}]
+(defn ls-middleware [service]
   (let [prom (promise)]
     (send-msg! service
                (new-tool-message service {:op "ls-middleware"})
@@ -207,7 +205,7 @@
                     (done #(deliver prom (get % :new-session)))))
     (deref prom 600 nil)))
 
-(defn send-input [{:keys [::state] :as service} input]
+(defn send-input [service input]
   (send-msg! service
              (new-message service {:op "stdin" :stdin (when input
                                                         (str input "\n"))})
@@ -221,14 +219,13 @@
 
 (declare create)
 
-(defn poll-for-responses [{:keys [::state] :as options} conn]
+(defn poll-for-responses [{:keys [::state] :as options} _conn]
   (let [retries (atom 60)]
     (loop []
       (when (polling? options)
         (let [continue
               (try
-                (when-let [{:keys [id out err value ns session] :as resp}
-                           (nrepl.transport/recv (:conn @state) 100)]
+                (when-let [resp (nrepl.transport/recv (:conn @state) 100)]
                   (reset! retries 60)
                   #_(tap> resp)
                   (dispatch-response! options resp))

src/clojure_mcp/prompts.clj

@@ -44,7 +44,7 @@
                                                     {:root-directory
                                                      working-dir})}]})
                   (clj-result-k
-                   {:description (str "Root directory not found.")
+                   {:description "Root directory not found."
                     :messages [{:role :user
                                 :content
                                 (str "Root directory not provided So this will not be a prompt." "::" working-dir "::")}]})))})

src/clojure_mcp/resources.clj

@@ -4,8 +4,7 @@
             [clojure-mcp.config :as config]
             [clojure-mcp.file-content :as file-content]
             [clojure-mcp.tools.project.core :as project]
-            [clojure-mcp.utils.file :as file-utils])
-  (:import [io.modelcontextprotocol.spec McpSchema$Resource McpSchema$ReadResourceResult]))
+            [clojure-mcp.utils.file :as file-utils]))
 
 (defn read-file [full-path]
   (let [file (io/file full-path)]

src/clojure_mcp/sexp/match.clj

@@ -1,6 +1,5 @@
 (ns clojure-mcp.sexp.match
-  (:require [rewrite-clj.zip :as z]
-            [rewrite-clj.parser :as p]))
+  (:require [rewrite-clj.zip :as z]))
 
 (defn match-sexpr
   "Return true if `pattern` matches `data`. 

src/clojure_mcp/sse_core.clj

@@ -1,6 +1,5 @@
 (ns clojure-mcp.sse-core
   (:require
-   [clojure-mcp.main :as main]
    [clojure-mcp.core :as core]
    [clojure-mcp.config :as config]
    [clojure-mcp.nrepl-launcher :as nrepl-launcher]

src/clojure_mcp/tool_system.clj

@@ -5,8 +5,7 @@
   (:require
    [clojure.string :as string]
    [clojure.walk :as walk]
-   [clojure.tools.logging :as log]
-   [clojure.data.json :as json]))
+   [clojure.tools.logging :as log]))
 
 ;; Core multimethods for tool behavior
 

test/clojure_mcp/tools/directory_tree/tool_test.clj

@@ -15,7 +15,7 @@
   (testing "tool-description returns a non-empty description"
     (let [description (tool-system/tool-description {:tool-type :directory-tree})]
       (is (string? description))
-      (is (not (empty? description))))))
+      (is (seq description)))))
 
 (deftest tool-schema-test
   (testing "tool-schema returns a valid schema with required path parameter"