Remove Emacs notification support and edit location tracking

Removes all Emacs editor integration features including:
- Delete emacs_integration.clj (242 lines)
- Remove emacs-buffer-modified-check and highlight-form from pipelines
- Remove capture-edit-offsets and edit-locations->offsets functions
- Remove :emacs-notify config option from schema and config.clj
- Remove :enable-emacs-notifications from tool configurations
- Update documentation (CONFIG.md, README.md, PROJECT_SUMMARY.md)
- Fix test assertion checking for removed :offsets field

Author: Bruce Hauman

CONFIG.md

@@ -60,19 +60,6 @@ The timestamp tracking system prevents accidental overwrites when files are modi
 - When you want automatic nREPL server management without separate terminal windows
 - In CI/CD environments where automatic startup is beneficial
 
-### `:emacs-notify`
-Boolean flag to enable Emacs integration notifications.
-
-Emacs notify is only a toy for now... it switches focus to the file
-being edited and highlights changes as they happen. There are
-probably better ways to handle this with auto-revert and existing
-Emacs libraries.
-
-**Prerequisites for Emacs Integration:**
-- `emacsclient` must be available in your system PATH
-- Emacs server must be running (start with `M-x server-start` or add `(server-start)` to your init file)
-- The integration allows the MCP server to communicate with your Emacs editor for enhanced development workflows
-
 ### `:scratch-pad-load`
 Boolean flag to automatically load the scratch pad on startup (default: `false`).
 

PROJECT_SUMMARY.md

@@ -131,7 +131,6 @@ your-project/
 
 ### Configuration Options
 - `allowed-directories`: Controls which directories MCP tools can access (security)
-- `emacs-notify`: Boolean flag for Emacs integration
 - `write-file-guard`: Controls file timestamp tracking behavior (default: `:partial-read`)
   - `:partial-read` - Both full and collapsed reads update timestamps (default)
   - `:full-read` - Only full reads update timestamps (safest)
@@ -187,7 +186,6 @@ your-project/
 ### Example Configuration
 ```edn
 {:allowed-directories ["." "src" "test" "resources" "../sibling-project"]
- :emacs-notify false
  :write-file-guard :partial-read
  :cljfmt true
  :bash-over-nrepl true

README.md

@@ -1007,7 +1007,6 @@ Configuration is extensively documented [here](doc/CONFIG.md).
                        "dev"
                        "/absolute/path/to/shared/code"
                        "../sibling-project"]
- :emacs-notify false
  :write-file-guard :full-read
  :cljfmt true
  :bash-over-nrepl true

resources/configs/example-tools-config.edn

@@ -1,6 +1,5 @@
 ;; Example configuration with tools-config
 {:allowed-directories ["." "src" "test" "resources"]
- :emacs-notify false
  :write-file-guard :partial-read
  :cljfmt true
  :bash-over-nrepl true

src/clojure_mcp/config.clj

@@ -86,7 +86,7 @@
                            :config config
                            :file-path canonical-path})))))))
 
-(defn process-config [{:keys [allowed-directories emacs-notify write-file-guard cljfmt bash-over-nrepl nrepl-env-type] :as config} user-dir]
+(defn process-config [{:keys [allowed-directories write-file-guard cljfmt bash-over-nrepl nrepl-env-type] :as config} user-dir]
   (let [ud (io/file user-dir)]
     (assert (and (.isAbsolute ud) (.isDirectory ud)))
     (when (some? write-file-guard)
@@ -104,8 +104,6 @@
                   (keep #(relative-to user-dir %))
                   distinct
                   vec))
-      (some? (:emacs-notify config))
-      (assoc :emacs-notify (boolean (:emacs-notify config)))
       (some? (:cljfmt config))
       (assoc :cljfmt (boolean (:cljfmt config)))
       (some? (:bash-over-nrepl config))
@@ -166,9 +164,6 @@
 (defn get-allowed-directories [nrepl-client-map]
   (get-config nrepl-client-map :allowed-directories))
 
-(defn get-emacs-notify [nrepl-client-map]
-  (get-config nrepl-client-map :emacs-notify))
-
 (defn get-nrepl-user-dir [nrepl-client-map]
   (get-config nrepl-client-map :nrepl-user-dir))
 

src/clojure_mcp/config/schema.clj

@@ -260,7 +260,6 @@
 
    ;; Core configuration
    [:allowed-directories {:optional true} [:sequential Path]]
-   [:emacs-notify {:optional true} :boolean]
    [:write-file-guard {:optional true} [:enum :full-read :partial-read false]]
    [:cljfmt {:optional true} :boolean]
    [:bash-over-nrepl {:optional true} :boolean]

src/clojure_mcp/tools/file_edit/pipeline.clj

@@ -9,7 +9,6 @@
    [clojure-mcp.tools.file-write.core :as file-write-core]
    [clojure-mcp.tools.agent-tool-builder.file-changes :as file-changes]
    [clojure-mcp.tools.unified-read-file.file-timestamps :as file-timestamps]
-   [clojure-mcp.utils.emacs-integration :as emacs]
    [clojure-mcp.config :as config]
    [clojure-mcp.linting :as linting]
    [clojure.spec.alpha :as s]
@@ -82,30 +81,6 @@
           ctx))
       ctx)))
 
-(defn capture-file-edit-offsets
-  "Captures the position offsets of the edited region in a file.
-   This function calculates character offsets for the edited region for highlighting.
-   
-   Requires ::form-pipeline/source and ::old-string in the context.
-   Adds ::form-pipeline/offsets to the context when successful."
-  [ctx]
-  (try
-    (let [source (::form-pipeline/source ctx)
-          old-string (::old-string ctx)]
-      (if (and source old-string (not-empty old-string))
-        (let [start-offset (when-let [so (str/index-of source old-string)]
-                             (inc so))
-              end-offset (when start-offset (+ start-offset (count old-string)))]
-          (if (and start-offset end-offset)
-            (assoc ctx ::form-pipeline/offsets [start-offset end-offset])
-            ctx))
-        ctx))
-    (catch Exception e
-      ;; Don't fail the pipeline if offsets can't be captured, just log it
-      ;; This allows non-Emacs workflows to continue
-      (log/error e (str "Warning: Failed to capture edit offsets -" (.getMessage e)))
-      ctx)))
-
 ;; This function is no longer needed - we'll use form-pipeline/highlight-form instead
 
 ;; Using update-file-timestamp from form-edit/pipeline instead
@@ -134,12 +109,10 @@
     ;; Pipeline for existing file edit
     (form-pipeline/thread-ctx
      initial-ctx
-     form-pipeline/emacs-buffer-modified-check
      form-pipeline/load-source ;; Load existing file
      file-changes/capture-original-file-content ;; Capture original content
      form-pipeline/check-file-modified ;; Check if file modified since last read
      validate-edit ;; Validate the edit (uniqueness, etc.)
-     capture-file-edit-offsets ;; Capture offsets for highlight
      perform-edit ;; Perform the actual edit
      ;; Only lint/repair Clojure files
      (fn [ctx]
@@ -156,8 +129,7 @@
          ctx
          (-> ctx
              form-pipeline/save-file
-             form-pipeline/update-file-timestamp
-             form-pipeline/highlight-form)))))) ;; Update the timestamp after save ;; Update the timestamp after save
+             form-pipeline/update-file-timestamp))))))
 
 ;; Format result for tool consumption
 (defn format-result
@@ -197,9 +169,9 @@
   ;; Create a test file
   (spit test-file "Line 1\nLine 2\nLine 3\nLine 4\nLine 5\n")
 
-  ;; Test the pipeline with simple edit and Emacs highlighting enabled
-  (def config {:enable-emacs-notifications true})
-  (def result (file-edit-pipeline test-file "Line 3" "Line 3 - EDITED" config))
+  ;; Test the pipeline with simple edit
+  (def config {})
+  (def result (file-edit-pipeline test-file "Line 3" "Line 3 - EDITED" nil config))
   (format-result result)
 
   ;; Test the pipeline with error (non-unique match)

src/clojure_mcp/tools/file_edit/tool.clj

@@ -12,11 +12,8 @@
 (defn create-file-edit-tool
   "Creates the file-edit tool configuration"
   [nrepl-client-atom]
-  (let [client @nrepl-client-atom
-        emacs-notify (config/get-emacs-notify client)]
-    {:tool-type :file-edit
-     :nrepl-client-atom nrepl-client-atom
-     :enable-emacs-notifications emacs-notify}))
+  {:tool-type :file-edit
+   :nrepl-client-atom nrepl-client-atom})
 
 ;; Implement the required multimethods for the file-edit tool
 (defmethod tool-system/tool-name :file-edit [_]

src/clojure_mcp/tools/form_edit/combined_edit_tool.clj

@@ -28,14 +28,10 @@
 
 ;; Tool creation function
 (defn create-edit-form-tool
-  "Creates the tool configuration for unified form editing operations.
-   Automatically inherits emacs notification preferences from the client."
+  "Creates the tool configuration for unified form editing operations."
   [nrepl-client-atom]
-  (let [client @nrepl-client-atom
-        emacs-notify (config/get-emacs-notify client)]
-    {:tool-type :clojure-edit-form
-     :nrepl-client-atom nrepl-client-atom
-     :enable-emacs-notifications emacs-notify}))
+  {:tool-type :clojure-edit-form
+   :nrepl-client-atom nrepl-client-atom})
 
 ;; Tool name implementation
 (defmethod tool-system/tool-name :clojure-edit-form [_]

src/clojure_mcp/tools/form_edit/pipeline.clj

@@ -5,7 +5,6 @@
   (:require
    [clojure-mcp.tools.form-edit.core :as core]
    [clojure-mcp.tools.agent-tool-builder.file-changes :as file-changes]
-   [clojure-mcp.utils.emacs-integration :as emacs]
    [clojure-mcp.utils.diff :as diff-utils]
    [clojure-mcp.tools.unified-read-file.file-timestamps :as file-timestamps]
    [clojure-mcp.config :as config]
@@ -95,23 +94,6 @@
           (assoc ::source (:content result))
           (assoc ::old-content (:content result))))))
 
-(defn emacs-buffer-modified-check
-  "Check if the emacs buffer is modified and saves it. When used before
-  check-file-modifed, it will trigger the modification error.
-  
-  A modified buffer is another level to check for file modifications.  
-
-  Marking it as modified. This in turn will trigger the check last modified 
-  to error out requiring the LLM to read the file before editing."
-  [ctx]
-  (let [file-path (::file-path ctx)
-        config (::config ctx)]
-    (if (and (emacs/config-enables-emacs-notifications? config)
-             (emacs/save-emacs-buffer-if-modified file-path))
-      ;; prevent race condition of write and then relying on read
-      (assoc ctx ::file-modifed true)
-      ctx)))
-
 (defn check-file-modified
   "Checks if the file has been modified since last read.
    Returns error if modified without being read again.
@@ -207,25 +189,6 @@
       {::error true
        ::message (str "Error parsing source: " (.getMessage e))})))
 
-(defn capture-edit-offsets
-  "Captures the position offsets of the current zipper location.
-   This should be called immediately after editing operations while position information is valid.
-   
-   Requires ::zloc in the context.
-   Adds ::offsets to the context when successful."
-  [ctx]
-  (try
-    (let [zloc (::zloc ctx)
-          positions (z/position-span zloc)
-          output-source (or (::output-source ctx) (z/root-string zloc))
-          offsets (core/zloc-offsets output-source positions)]
-      (assoc ctx ::offsets offsets))
-    (catch Exception e
-      ;; Don't fail the pipeline if offsets can't be captured, just log it
-      ;; This allows non-Emacs workflows to continue
-      (log/error e "Warning: Failed to capture edit offsets -" (.getMessage e))
-      ctx)))
-
 (defn validate-form-type
   "Validates that the form type is supported for the operation.
    Returns the context unchanged if valid, or error context if invalid.
@@ -376,25 +339,6 @@
                    (str "Changes made, but diff generation failed: " (.getMessage e)))))]
     (assoc ctx ::diff diff)))
 
-#_(defn emacs-set-auto-revert
-    "Ensures that the file is open in Emacs with auto-revert-mode enabled if notifications are enabled.
-   Requires ::file-path and ::config in the context."
-    [ctx]
-    (try
-      (let [file-path (::file-path ctx)
-            config (::config ctx)]
-      ;; Only notify if emacs notifications are enabled in config
-        (if (emacs/config-enables-emacs-notifications? config)
-          (do
-            (emacs/ensure-auto-revert file-path) ;; Now ensure-auto-revert is always async
-            ctx)
-        ;; Otherwise return context unchanged
-          ctx))
-    ;; Fail silently if emacs isn't started
-      (catch Exception _
-      ;; Return context unchanged if Emacs integration fails
-        ctx)))
-
 (defn save-file
   "Saves the updated source to the file, creating parent directories if needed.
    Requires ::output-source and ::file-path in the context.
@@ -430,22 +374,6 @@
       (file-timestamps/update-file-timestamp-to-current-mtime! nrepl-client-atom file-path))
     ctx))
 
-(defn highlight-form
-  "Highlights the edited form in Emacs if notifications are enabled.
-   Requires ::file-path, ::offsets, and ::config in the context."
-  [ctx]
-  (try
-    (let [[start end] (::offsets ctx)
-          config (::config ctx)]
-      ;; Only notify if emacs notifications are enabled in config
-      (when (emacs/config-enables-emacs-notifications? config)
-        (emacs/highlight-region (::file-path ctx) start end 2.0))
-      ctx)
-    ;; Fail silently to support non-emacs workflow
-    (catch Exception _
-      ;; Return context unchanged if highlighting fails
-      ctx)))
-
 ;; Format result for tool consumption
 (defn format-result
   "Format the result of the pipeline for tool consumption.
@@ -504,15 +432,13 @@
      ctx
      lint-repair-code
      validate-form-type
-     emacs-buffer-modified-check
      load-source
      file-changes/capture-original-file-content
      check-file-modified
      enhance-defmethod-name
      parse-source
      find-form
      edit-form
-     capture-edit-offsets
      zloc->output-source
      format-source
      determine-file-type
@@ -522,21 +448,7 @@
          ctx
          (-> ctx
              save-file
-             update-file-timestamp
-             highlight-form))))))
-
-(defn edit-locations->offsets [ctx]
-  (try
-    (let [zloc (::zloc ctx)
-          positions (last (::edit-locations ctx))
-          output-source (or (::output-source ctx) (z/root-string zloc))
-          offsets (core/zloc-offsets output-source positions)]
-      (assoc ctx ::offsets offsets))
-    (catch Exception e
-      ;; Don't fail the pipeline if offsets can't be captured, just log it
-      ;; This allows non-Emacs workflows to continue
-      (log/error e (str "Warning: Failed to capture edit offsets -" (ex-message e)))
-      ctx)))
+             update-file-timestamp))))))
 
 (defn edit-sexp
   [{:keys [::zloc ::match-form ::new-form ::operation ::replace-all ::whitespace-sensitive] :as ctx}]
@@ -585,14 +497,12 @@
      ctx
      #(lint-repair-code % ::match-form)
      #(lint-repair-code % ::new-form)
-     emacs-buffer-modified-check
      load-source
      file-changes/capture-original-file-content
      check-file-modified
      parse-source
      edit-sexp
      zloc->output-source
-     edit-locations->offsets
      format-source
      determine-file-type
      generate-diff
@@ -601,8 +511,7 @@
          ctx
          (-> ctx
              save-file
-             update-file-timestamp
-             highlight-form))))))
+             update-file-timestamp))))))
 
 (comment
   ;; Example usage of the pipelines
@@ -613,4 +522,4 @@
                         "(defn example-fn [x y]\n  (* x y))"
                         :after
                         nil
-                        {:enable-emacs-notifications true})))
+                        {})))