From 57cefad1cedde432a5820c4e460a0a6e31fe0877 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Brandon=F0=9F=8C=A9=EF=B8=8FH?= Date: Wed, 5 Nov 2025 08:10:02 -0800 Subject: [PATCH 1/2] this should break the build --- src/SemanticKernel/Server/YaapServer.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/SemanticKernel/Server/YaapServer.cs b/src/SemanticKernel/Server/YaapServer.cs index d60f66a..b847235 100644 --- a/src/SemanticKernel/Server/YaapServer.cs +++ b/src/SemanticKernel/Server/YaapServer.cs @@ -33,7 +33,7 @@ public abstract class YaapServer(Kernel kernel, IDistributedCach protected override Task HandleHelloCustomAsync(YaapClientDetail clientDetail, CancellationToken cancellationToken) { _log.AddingExpertNameToSemanticKernelPlugins(clientDetail.Name); - _log.ClientDetail(clientDetail); + _log.ClientDetail(clientDetail) kernel.ImportPluginFromFunctions(clientDetail.Name, [kernel.CreateFunctionFromMethod( async (string prompt) => await CallExpertAsync(clientDetail, prompt, cancellationToken), From 3e0d0210c1ee3e7023cb945c4bb9b791673fe6a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Brandon=F0=9F=8C=A9=EF=B8=8FH?= Date: Wed, 5 Nov 2025 08:20:48 -0800 Subject: [PATCH 2/2] dotnet test too smart was only building what was needed for tests, so that was fun to find out --- .github/workflows/pr-build.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-build.yaml b/.github/workflows/pr-build.yaml index f2c129a..1fe86aa 100644 --- a/.github/workflows/pr-build.yaml +++ b/.github/workflows/pr-build.yaml @@ -26,5 +26,8 @@ jobs: with: dotnet-version: "8.x" - - name: Build & Run UTs - run: dotnet test src/Yaap.sln -c ${{ matrix.configuration }} + - name: Build + run: dotnet build src/Yaap.sln -c ${{ matrix.configuration }} + + - name: Run UTs + run: dotnet test src/Yaap.sln -c ${{ matrix.configuration }} --no-build