Tweak configuration

No auto-detection, just use the config with defaults.
Detection isn't realiable. See #25
Escape php binary and add optional arguments.

Author: barryvdh

readme.md

@@ -34,7 +34,18 @@ You should now be able to use the async driver in config/queue.php
         ...
         'async' => array(
             'driver' => 'async',
-            'binary' => 'php',  // Optional: path to php binary, defaults to 'php'. Set to null to autodetect.
+        ),
+        ...
+    }
+
+By default, `php` is used as the binary path to PHP. You can change this by adding the `binary` option to the queue config. You can also add extra arguments (for HHVM for example)
+
+    'connections' => array(
+        ...
+        'async' => array(
+            'driver' => 'async',
+            'binary' => 'php',
+            'binary_args' => '',
         ),
         ...
     }

src/AsyncQueue.php

@@ -3,18 +3,18 @@
 
 use Barryvdh\Queue\Models\Job;
 use Illuminate\Queue\SyncQueue;
-use Symfony\Component\Process\PhpExecutableFinder;
 
 class AsyncQueue extends SyncQueue
 {
-    protected $binary;
+    /** @var array */
+    protected $config;
 
+    /**
+     * @param array $config
+     */
     public function __construct(array $config)
     {
-        $this->binary = array_key_exists('binary', $config) ? $config['binary'] : 'phpauto';
-        if (!$this->binary) {
-            $this->binary = $this->getPhpBinary();
-        }
+        $this->config = $config;
     }
 
     /**
@@ -83,16 +83,24 @@ protected function getCommand($jobId)
         $cmd = '%s artisan queue:async %d --env=%s';
         $cmd = $this->getBackgroundCommand($cmd);
 
+        $binary = $this->getPhpBinary();
         $environment = $this->container->environment();
 
-        return sprintf($cmd, $this->binary, $jobId, $environment);
+        return sprintf($cmd, $binary, $jobId, $environment);
     }
 
+    /**
+     * Get the escaped PHP Binary from the configuration
+     *
+     * @return string
+     */
     protected function getPhpBinary()
     {
-        $phpfinder = new PhpExecutableFinder();
-        $path = escapeshellarg($phpfinder->find(false));
-        $args = implode(' ', $phpfinder->findArguments());
+        $path = escapeshellarg($this->config['binary']);
+        $args = $this->config['binary_args'];
+        if(is_array($args)){
+            $args = implode(' ', $args);
+        }
         return trim($path.' '.$args);
     }
 

src/Connectors/AsyncConnector.php

@@ -7,6 +7,16 @@
 
 class AsyncConnector implements ConnectorInterface
 {
+    /**
+     * Default configuration
+     *
+     * @var array
+     */
+    protected $defaults = array(
+        'binary'        => 'php',
+        'binary_args'   => '',
+    );
+
     /**
      * Establish a queue connection.
      *
@@ -16,6 +26,7 @@ class AsyncConnector implements ConnectorInterface
      */
     public function connect(array $config)
     {
+        $config = array_merge($this->defaults, $config);
         return new AsyncQueue($config);
     }
 }