fix: Address Hyperparameter issue , validate s3 output path, additional unit tests #5376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsareddy0329
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
Collaborator
|
should process_hyperparameter be in util class, rather than in separate fine-tuner interfaces ? |
Contributor
Author
The main reason to not choose a common method is , they have different parameter keys for each technique and esp. RLAIF needs a special handling model and prompt parameters. |
mufaddal-rohawala
approved these changes
Dec 7, 2025
| """Remove hyperparameter keys that are handled by constructor inputs.""" | ||
| if self.hyperparameters: | ||
| # Remove keys that are handled by constructor inputs | ||
| if hasattr(self.hyperparameters, 'data_path'): |
Member
There was a problem hiding this comment.
nit: there is code redundancy improvements possible here. Have an ignore_list somewhere in constants and look over it to delattr.
| # Validate and set EULA acceptance | ||
| self.accept_eula = _validate_eula_for_gated_model(model, accept_eula, is_gated_model) | ||
|
|
||
| def _process_hyperparameters(self): |
Member
There was a problem hiding this comment.
nit: is there opportunity to have a common mthod somwehere? rather than haning each class take this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing:
pytest tests/unit/train/
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html ============================================ 1027 passed, 13 skipped, 45 warnings in 33.89s ============================================By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.