Skip to content

Commit 801601d

Browse files
authored
ignore error when get tags (#367)
1 parent 2023afc commit 801601d

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

pkg/aws/cloud.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ func (c *defaultCloud) IsArnManaged(arn string) (bool, error) {
110110
tagsReq := &vpclattice.ListTagsForResourceInput{ResourceArn: &arn}
111111
resp, err := c.lattice.ListTagsForResource(tagsReq)
112112
if err != nil {
113-
return false, err
113+
return false, nil
114114
}
115115
isManaged := c.ContainsManagedBy(resp.Tags)
116116
return isManaged, nil

pkg/aws/cloud_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,8 @@ func TestIsArnManaged(t *testing.T) {
7575
t.Run("error", func(t *testing.T) {
7676
lat.EXPECT().ListTagsForResource(gomock.Any()).
7777
Return(nil, errors.New(":("))
78-
_, err := cl.IsArnManaged("arn")
79-
assert.NotNil(t, err)
78+
managed, err := cl.IsArnManaged("arn")
79+
assert.Nil(t, err)
80+
assert.False(t, managed)
8081
})
8182
}

0 commit comments

Comments
 (0)