Skip to content

Commit 15d0899

Browse files
authored
add DISABLE_TAGGING_SERVICE_API env to helm chart (#655)
1 parent 293531f commit 15d0899

File tree

3 files changed

+17
-0
lines changed

3 files changed

+17
-0
lines changed

docs/guides/environment.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,3 +88,17 @@ When set as "true", the controller will start the webhook listener responsible f
8888
successfully without the TLS certificate for the webhook in place. While this can be fixed by running
8989
`scripts/gen-webhook-cert.sh`, it requires manual action. The webhook is enabled by default for the Helm install
9090
as the Helm install will also generate the necessary certificate.
91+
92+
---
93+
94+
#### `DISABLE_TAGGING_SERVICE_API`
95+
96+
**Type:** *string*
97+
98+
**Default:** ""
99+
100+
When set as "true", the controller will not use the [AWS Resource Groups Tagging API](https://docs.aws.amazon.com/resourcegroupstagging/latest/APIReference/overview.html).
101+
102+
The Resource Groups Tagging API is only available on the public internet and customers using private clusters will need to enable this feature. When enabled, the controller will use VPC Lattice APIs to lookup tags which are not as performant and requires more API calls.
103+
104+
The Helm chart sets this value to "false" by default.

helm/templates/deployment.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,8 @@ spec:
9595
value: {{ .Values.log.level | quote }}
9696
- name: WEBHOOK_ENABLED
9797
value: {{ .Values.webhookEnabled | quote }}
98+
- name: DISABLE_TAGGING_SERVICE_API
99+
value: {{ .Values.disableTaggingServiceApi | quote }}
98100
terminationGracePeriodSeconds: 10
99101
volumes:
100102
- name: webhook-cert

helm/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ clusterName:
7878
defaultServiceNetwork:
7979
latticeEndpoint:
8080
webhookEnabled: true
81+
disableTaggingServiceApi: false
8182

8283
# TLS cert/key for the webhook. If specified, values must be base64 encoded
8384
webhookTLS:

0 commit comments

Comments
 (0)