remove finalizer and use LazyCleaner implementation from pgjdbc #1625
+464
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiyvamz
reviewed
Dec 2, 2025
| } | ||
|
|
||
| private boolean startThread() { | ||
| Thread thread = threadFactory.newThread(new Runnable() { |
Contributor
There was a problem hiding this comment.
Should the thread be a daemon thread?
Contributor
Author
There was a problem hiding this comment.
Actually we do not use a daemon thread in pgjdbc
sergiyvamz
reviewed
Dec 2, 2025
|
|
||
| public void releaseResources() { | ||
| this.pluginManager.releaseResources(); | ||
| if (this.pluginService instanceof CanReleaseResources) { |
Contributor
There was a problem hiding this comment.
Should we clean up pluginManager similar way?
Contributor
Author
There was a problem hiding this comment.
we would have to pass pluginManager into LazyCleaner, but sure
Contributor
Author
|
Hold off on doing anything with this. Upstream we are looking at creating a multi-version jar with java 11 and using the built-in cleaner and some modifications to this implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
see $subject
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.