Commit a2dc2db
authored
Remove dockerhub login step and use ECR public gallery ubuntu image (#78)
This is required so that we do not need to support dockerhub and its credentials.
1. Remove dockerhub login step from the codebuild spec file.
2. Use [ECR public gallery ubuntu image](https://gallery.ecr.aws/ubuntu/ubuntu) in the Canary Docker Image instead
### Testing
For testing I added this commit on top of the `canary` branch and pushed to a new upstream branch [`docker-on-ecr-on-canary-branch`](https://github.com/aws-controllers-k8s/sagemaker-controller/tree/docker-on-ecr-on-canary-branch). Then ran the canary test job on this branch.1 parent 0b96ed2 commit a2dc2db
2 files changed
+1
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | 13 | | |
17 | 14 | | |
18 | 15 | | |
| |||
0 commit comments