Skip to content

Commit 806e45b

Browse files
surajkotasurajkota
authored
terminal codes clean up (#89)
Description of changes: Be conservative in the list of terminal codes. Specify only those for which the user needs to change a value in spec. - looked at each resource's APIs errors and removed the ones that are not thrown in any of the CRUD APIs Long pending backlog item Testing: will rely on PR Build By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 3657e9c commit 806e45b

File tree

16 files changed

+29
-356
lines changed

16 files changed

+29
-356
lines changed

‎apis/v1alpha1/ack-generate-metadata.yaml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
ack_generate_info:
2-
build_date: "2021-08-30T20:10:42Z"
2+
build_date: "2021-08-31T02:17:13Z"
33
build_hash: c77aa9c75d944952dee198029ba9822691cd82b0
44
go_version: go1.16.4 linux/amd64
55
version: v0.6.0
66
api_directory_checksum: dd5cd5b0cfebeb75eae65c53ab3195a9935a4b87
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.38.11
99
generator_config_info:
10-
file_checksum: 84ebf8b8fb4e8a73f6c7fbaab033e3a75436e08e
10+
file_checksum: 70f99c3c40b26a6e73a2b2c391291f9441bc208d
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation
14-
timestamp: 2021-08-30 20:10:45.71009265 +0000 UTC
14+
timestamp: 2021-08-31 02:17:16.250470244 +0000 UTC

‎apis/v1alpha1/generator.yaml‎

Lines changed: 1 addition & 110 deletions
Original file line numberDiff line numberDiff line change
@@ -35,39 +35,19 @@ resources:
3535
code: ValidationException
3636
message_prefix: Could not find model
3737
terminal_codes:
38-
- ResourceLimitExceeded
39-
- ResourceNotFound
40-
- ResourceInUse
41-
- OptInRequired
4238
- InvalidParameterCombination
4339
- InvalidParameterValue
4440
- MissingParameter
45-
- MissingAction
46-
- InvalidClientTokenId
47-
- InvalidQueryParameter
48-
- MalformedQueryString
49-
- InvalidAction
50-
- UnrecognizedClientException
5141
EndpointConfig:
5242
exceptions:
5343
errors:
5444
404:
5545
code: ValidationException
5646
message_prefix: Could not find endpoint configuration
5747
terminal_codes:
58-
- ResourceLimitExceeded
59-
- ResourceNotFound
60-
- ResourceInUse
61-
- OptInRequired
6248
- InvalidParameterCombination
6349
- InvalidParameterValue
6450
- MissingParameter
65-
- MissingAction
66-
- InvalidClientTokenId
67-
- InvalidQueryParameter
68-
- MalformedQueryString
69-
- InvalidAction
70-
- UnrecognizedClientException
7151
Endpoint:
7252
reconcile:
7353
requeue_on_success_seconds: 30
@@ -78,19 +58,9 @@ resources:
7858
code: ValidationException
7959
message_prefix: Could not find endpoint
8060
terminal_codes:
81-
- ResourceLimitExceeded
82-
- ResourceNotFound
83-
- ResourceInUse
84-
- OptInRequired
8561
- InvalidParameterCombination
8662
- InvalidParameterValue
8763
- MissingParameter
88-
- MissingAction
89-
- InvalidClientTokenId
90-
- InvalidQueryParameter
91-
- MalformedQueryString
92-
- InvalidAction
93-
- UnrecognizedClientException
9464
# Custom error
9565
- EndpointUpdateError
9666
hooks:
@@ -328,18 +298,11 @@ resources:
328298
404:
329299
code: ResourceNotFound
330300
terminal_codes:
331-
- ResourceLimitExceeded
332301
- ResourceNotFound
333302
- ResourceInUse
334-
- OptInRequired
335303
- InvalidParameterCombination
336304
- InvalidParameterValue
337305
- MissingParameter
338-
- MissingAction
339-
- InvalidQueryParameter
340-
- MalformedQueryString
341-
- InvalidAction
342-
- UnrecognizedClientException
343306
fields:
344307
JobDefinitionArn:
345308
is_arn: true
@@ -351,18 +314,11 @@ resources:
351314
404:
352315
code: ResourceNotFound
353316
terminal_codes:
354-
- ResourceLimitExceeded
355317
- ResourceNotFound
356318
- ResourceInUse
357-
- OptInRequired
358319
- InvalidParameterCombination
359320
- InvalidParameterValue
360321
- MissingParameter
361-
- MissingAction
362-
- InvalidQueryParameter
363-
- MalformedQueryString
364-
- InvalidAction
365-
- UnrecognizedClientException
366322
fields:
367323
JobDefinitionArn:
368324
is_arn: true
@@ -374,18 +330,11 @@ resources:
374330
404:
375331
code: ResourceNotFound
376332
terminal_codes:
377-
- ResourceLimitExceeded
378333
- ResourceNotFound
379334
- ResourceInUse
380-
- OptInRequired
381335
- InvalidParameterCombination
382336
- InvalidParameterValue
383337
- MissingParameter
384-
- MissingAction
385-
- InvalidQueryParameter
386-
- MalformedQueryString
387-
- InvalidAction
388-
- UnrecognizedClientException
389338
fields:
390339
JobDefinitionArn:
391340
is_arn: true
@@ -397,18 +346,11 @@ resources:
397346
404:
398347
code: ResourceNotFound
399348
terminal_codes:
400-
- ResourceLimitExceeded
401349
- ResourceNotFound
402350
- ResourceInUse
403-
- OptInRequired
404351
- InvalidParameterCombination
405352
- InvalidParameterValue
406353
- MissingParameter
407-
- MissingAction
408-
- InvalidQueryParameter
409-
- MalformedQueryString
410-
- InvalidAction
411-
- UnrecognizedClientException
412354
fields:
413355
JobDefinitionArn:
414356
is_arn: true
@@ -423,18 +365,11 @@ resources:
423365
404:
424366
code: ResourceNotFound
425367
terminal_codes:
426-
- ResourceLimitExceeded
427368
- ResourceNotFound
428369
- ResourceInUse
429-
- OptInRequired
430370
- InvalidParameterCombination
431371
- InvalidParameterValue
432372
- MissingParameter
433-
- MissingAction
434-
- InvalidQueryParameter
435-
- MalformedQueryString
436-
- InvalidAction
437-
- UnrecognizedClientException
438373
hooks:
439374
sdk_create_post_set_output:
440375
code: rm.customSetOutput(desired, aws.String("Pending"), ko)
@@ -485,18 +420,9 @@ resources:
485420
code: ValidationException
486421
message_suffix: does not exist.
487422
terminal_codes:
488-
- ResourceLimitExceeded
489-
- ResourceNotFound
490-
- ResourceInUse
491-
- OptInRequired
492423
- InvalidParameterCombination
493424
- InvalidParameterValue
494425
- MissingParameter
495-
- MissingAction
496-
- InvalidQueryParameter
497-
- MalformedQueryString
498-
- InvalidAction
499-
- UnrecognizedClientException
500426
- ConflictException
501427
# Custom error to disable support for Versioned
502428
# Model Package
@@ -562,18 +488,11 @@ resources:
562488
404:
563489
code: ResourceNotFound
564490
terminal_codes:
565-
- ResourceInUse
566-
- ResourceLimitExceeded
567491
- ResourceNotFound
568-
- InvalidAction
569-
- InvalidClientTokenId
492+
- ResourceInUse
570493
- InvalidParameterCombination
571494
- InvalidParameterValue
572-
- InvalidQueryParameter
573-
- MalformedQueryString
574-
- MissingAction
575495
- MissingParameter
576-
- OptInRequired
577496
hooks:
578497
delta_pre_compare:
579498
code: customSetDefaults(a, b)
@@ -606,19 +525,9 @@ resources:
606525
code: ValidationException
607526
message_prefix: RecordNotFound
608527
terminal_codes:
609-
- ResourceLimitExceeded
610-
- ResourceNotFound
611-
- ResourceInUse
612-
- OptInRequired
613528
- InvalidParameterCombination
614529
- InvalidParameterValue
615530
- MissingParameter
616-
- MissingAction
617-
- InvalidClientTokenId
618-
- InvalidQueryParameter
619-
- MalformedQueryString
620-
- InvalidAction
621-
- UnrecognizedClientException
622531
hooks:
623532
sdk_read_one_post_set_output:
624533
template_path: notebook_instance/sdk_read_one_post_set_output.go.tpl
@@ -667,18 +576,9 @@ resources:
667576
code: ValidationException
668577
message_suffix: does not exist.
669578
terminal_codes:
670-
- ResourceLimitExceeded
671-
- ResourceNotFound
672-
- ResourceInUse
673-
- OptInRequired
674579
- InvalidParameterCombination
675580
- InvalidParameterValue
676581
- MissingParameter
677-
- MissingAction
678-
- InvalidQueryParameter
679-
- MalformedQueryString
680-
- InvalidAction
681-
- UnrecognizedClientException
682582
- ConflictException
683583
fields:
684584
ModelPackageGroupStatus:
@@ -702,18 +602,9 @@ resources:
702602
code: ValidationException
703603
message_prefix: Unable to describe Notebook Instance Lifecycle Config
704604
terminal_codes:
705-
- ResourceLimitExceeded
706-
- ResourceNotFound
707-
- ResourceInUse
708-
- OptInRequired
709605
- InvalidParameterCombination
710606
- InvalidParameterValue
711607
- MissingParameter
712-
- MissingAction
713-
- InvalidQueryParameter
714-
- MalformedQueryString
715-
- InvalidAction
716-
- UnrecognizedClientException
717608
hooks:
718609
delta_post_compare:
719610
template_path: notebook_instance_lifecycle_config/delta_post_compare.go.tpl

0 commit comments

Comments
 (0)