Return a terminal error when sdkUpdate is not implemented (#372)

a-hilaly · web-flow · commit fd065719969b · 2023-01-25T13:59:42.000-08:00
Currently the generated sdk code throws a simple error when `sdkUpdate` is not implemented. This is only observable in the controller logs and users are not able to read this information from their resource's status/conditions. This patch forces `sdkUpdate` to return a terminal error instead of a normal error. Fixes aws-controllers-k8s/community#1521 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
diff --git a/templates/pkg/resource/sdk_update_not_implemented.go.tpl b/templates/pkg/resource/sdk_update_not_implemented.go.tpl
@@ -5,7 +5,6 @@ func (rm *resourceManager) sdkUpdate(
 	latest *resource,
 	delta *ackcompare.Delta,
 ) (*resource, error) {
-	// TODO(jaypipes): Figure this out...
-	return nil, ackerr.NotImplemented
+	return nil, ackerr.NewTerminalError(ackerr.NotImplemented)
 }
 {{- end -}}

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,6 @@ func (rm *resourceManager) sdkUpdate(`
`5`	`5`	`latest *resource,`
`6`	`6`	`delta *ackcompare.Delta,`
`7`	`7`	`) (*resource, error) {`
`8`		`- // TODO(jaypipes): Figure this out...`
`9`		`- return nil, ackerr.NotImplemented`
	`8`	`+ return nil, ackerr.NewTerminalError(ackerr.NotImplemented)`
`10`	`9`	`}`
`11`	`10`	`{{- end -}}`