Commit a6a8a09
authored
using go env GOARCH to detect system arch instead of uname (#373)
Issue #, if available:
N/A
Description of changes:
`uname` does not always match the friendly arch that operator-sdk, an example is that on a normal mac you get `x86_64` which fails to download since operator-sdk is released as `amd64`, there could be other examples as well.
Other things I thought of, since we might not want to rely on `go env` and be tied to go-tools:
- `uname -m | tr '[:upper:]' '[:lower:]' | sed 's/x86_64/amd64/g'`
- have this script take in arch as an arg
Let me know which approach would be best
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Signed-off-by: Adam D. Cornett <adc@redhat.com>1 parent 18745aa commit a6a8a09
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
0 commit comments