Nil check for IsSync (#308)

Issue #, if available:
aws-controllers-k8s/community#1231

Description of changes:
Nil check fix for IsSync needed for MemoryDB and
Fixed a compare ignore bug.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: nmvk

pkg/generate/code/synced.go

@@ -121,7 +121,12 @@ func scalarFieldEqual(
 ) string {
 	out := ""
 	fieldPath := fmt.Sprintf("%s.%s", resVarName, *condCfg.Path)
-
+	// if r.ko.Status.Status == nil
+	out += fmt.Sprintf("\tif %s == nil {\n", fieldPath)
+	// return false, nil
+	out += "\t\treturn false, nil\n"
+	// }
+	out += "\t}\n"
 	valuesSlice := ""
 	switch goType {
 	case "string":
@@ -174,9 +179,8 @@ func fieldPathSafeEqual(
 	subFieldPath := rootPath
 	for index, shape := range shapes {
 		if index == len(shapes)-1 {
-			// Some aws-sdk-go scalar shapes don't contain the real name of a shape
-			// In this case we use the full path given in condition.Path
-			subFieldPath = fmt.Sprintf("%s.%s", resVarName, *condCfg.Path)
+			// We would check for nil in scalarFieldEqual method so no need to loop anymore
+			break
 		} else {
 			subFieldPath += "." + shape.Shape.ShapeName
 		}

pkg/generate/code/synced_test.go

@@ -33,14 +33,23 @@ func TestSyncedLambdaFunction(t *testing.T) {
 	require.NotNil(crd)
 
 	expectedSyncedConditions := `
+	if r.ko.Status.State == nil {
+		return false, nil
+	}
 	stateCandidates := []string{"AVAILABLE", "ACTIVE"}
 	if !ackutil.InStrings(*r.ko.Status.State, stateCandidates) {
 		return false, nil
 	}
+	if r.ko.Status.LastUpdateStatus == nil {
+		return false, nil
+	}
 	lastUpdateStatusCandidates := []string{"AVAILABLE", "ACTIVE"}
 	if !ackutil.InStrings(*r.ko.Status.LastUpdateStatus, lastUpdateStatusCandidates) {
 		return false, nil
 	}
+	if r.ko.Status.CodeSize == nil {
+		return false, nil
+	}
 	codeSizeCandidates := []int{1, 2}
 	if !ackutil.InStrings(*r.ko.Status.CodeSize, codeSizeCandidates) {
 		return false, nil
@@ -64,6 +73,9 @@ func TestSyncedDynamodbTable(t *testing.T) {
 	require.NotNil(crd)
 
 	expectedSyncedConditions := `
+	if r.ko.Status.TableStatus == nil {
+		return false, nil
+	}
 	tableStatusCandidates := []string{"AVAILABLE", "ACTIVE"}
 	if !ackutil.InStrings(*r.ko.Status.TableStatus, tableStatusCandidates) {
 		return false, nil
@@ -78,6 +90,9 @@ func TestSyncedDynamodbTable(t *testing.T) {
 	if !ackutil.InStrings(*r.ko.Spec.ProvisionedThroughput.ReadCapacityUnits, provisionedThroughputCandidates) {
 		return false, nil
 	}
+	if r.ko.Status.ItemCount == nil {
+		return false, nil
+	}
 	itemCountCandidates := []int{0}
 	if !ackutil.InStrings(*r.ko.Status.ItemCount, itemCountCandidates) {
 		return false, nil