Fix required fields for renamed ReadOne input (#113)

Description of changes:
The generator was failing with a panic when it could not find a renamed field in the `ReadOne` describe/create operation while creating the `GoCodeRequiredFieldsMissingFromReadOneInput` template.

This pull request ensures the code attempts to rename the field, if specified in the config, before using the field name in any output.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: RedbackThomson

pkg/generate/code/check.go

@@ -87,6 +87,7 @@ func CheckRequiredFieldsMissingFromShape(
 		r,
 		koVarName,
 		indentLevel,
+		op,
 		shape,
 	)
 }
@@ -95,6 +96,7 @@ func checkRequiredFieldsMissingFromShape(
 	r *model.CRD,
 	koVarName string,
 	indentLevel int,
+	op *awssdkmodel.Operation,
 	shape *awssdkmodel.Shape,
 ) string {
 	indent := strings.Repeat("\t", indentLevel)
@@ -134,9 +136,15 @@ func checkRequiredFieldsMissingFromShape(
 		cleanMemberName := cleanMemberNames.Camel
 
 		resVarPath := koVarName
-		_, found := r.SpecFields[memberName]
-		if found {
+		// Check that the field has potentially been renamed
+		renamedName, wasRenamed := r.InputFieldRename(
+			op.Name, memberName,
+		)
+		_, found := r.SpecFields[renamedName]
+		if found && !wasRenamed {
 			resVarPath = resVarPath + r.Config().PrefixConfig.SpecField + "." + cleanMemberName
+		} else if found {
+			resVarPath = resVarPath + r.Config().PrefixConfig.SpecField + "." + renamedName
 		} else {
 			_, found = r.StatusFields[memberName]
 			if !found {

pkg/generate/code/check_test.go

@@ -94,3 +94,24 @@ func TestCheckRequiredFields_Attributes_StatusAndSpecField(t *testing.T) {
 		strings.TrimSpace(gotCode),
 	)
 }
+
+func TestCheckRequiredFields_RenamedSpecField(t *testing.T) {
+	assert := assert.New(t)
+	require := require.New(t)
+
+	g := testutil.NewGeneratorForService(t, "eks")
+
+	crd := testutil.GetCRDByName(t, g, "FargateProfile")
+	require.NotNil(crd)
+
+	expRequiredFieldsCode := `
+	return r.ko.Spec.ClusterName == nil || r.ko.Spec.Name == nil
+`
+	gotCode := code.CheckRequiredFieldsMissingFromShape(
+		crd, model.OpTypeGet, "r.ko", 1,
+	)
+	assert.Equal(
+		strings.TrimSpace(expRequiredFieldsCode),
+		strings.TrimSpace(gotCode),
+	)
+}