Only return MetaObject from AWSResource.MetaObject() call (#184)

vijtrip2 · web-flow · commit 0dad432caff7 · 2021-09-08T13:57:27.000-07:00
Issue #, if available: aws-controllers-k8s/community#937 Description of changes: * For implementation of AWSResource.MetaObject, we were returning the complete resource. * This change only returns 'ObjectMeta' from AWSResource which is the implementation of 'metav1.Object' inside resource struct * returning only the relevant members helps in metadata comparison correctly with `ackcompare.MetaV1ObjectEqual` --------------- * Unit tests successful * Successful local kind e2e test for newly generated dynamodb controller By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
diff --git a/templates/pkg/resource/resource.go.tpl b/templates/pkg/resource/resource.go.tpl
@@ -46,7 +46,7 @@ func (r *resource) RuntimeObject() k8srt.Object {
 // MetaObject returns the Kubernetes apimachinery/apis/meta/v1.Object
 // representation of the AWSResource
 func (r *resource) MetaObject() metav1.Object {
-	return r.ko
+	return r.ko.GetObjectMeta()
 }
 
 // RuntimeMetaObject returns an object that implements both the Kubernetes

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ func (r *resource) RuntimeObject() k8srt.Object {`
`46`	`46`	`// MetaObject returns the Kubernetes apimachinery/apis/meta/v1.Object`
`47`	`47`	`// representation of the AWSResource`
`48`	`48`	`func (r *resource) MetaObject() metav1.Object {`
`49`		`- return r.ko`
	`49`	`+ return r.ko.GetObjectMeta()`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`// RuntimeMetaObject returns an object that implements both the Kubernetes`