Commit 06f01f2
authored
fix(group): group redeclared issue fixed (#251)
Signed-off-by: haarchri <chhaar30@googlemail.com>
Issue aws-controllers-k8s/community#1108 crossplane-contrib/provider-aws#1025
Description of changes:
changed const Group to CRDGroup to fits generated Group for IAM
without this PR:
make generate failed with:
`panic: interface conversion: types.Type is nil, not *types.Named`

https://github.com/haarchri/provider-aws/blob/error/group/apis/iam/v1alpha1/zz_groupversion_info.go#L28
https://github.com/haarchri/provider-aws/blob/error/group/apis/iam/v1alpha1/zz_service_linked_role.go#L144
https://github.com/haarchri/provider-aws/blob/error/group/apis/iam/v1alpha1/zz_types.go#L102
fixed issue with this PR:
code-generator works in crossplane for iam:
https://github.com/haarchri/provider-aws/blob/fix/group/apis/iam/v1alpha1/zz_groupversion_info.go#L28
https://github.com/haarchri/provider-aws/blob/fix/group/apis/iam/v1alpha1/zz_groupversion_info.go#L34
https://github.com/haarchri/provider-aws/blob/fix/group/apis/iam/v1alpha1/zz_service_linked_role.go#L144
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.1 parent 26e5da2 commit 06f01f2
File tree
2 files changed
+4
-4
lines changed- templates/crossplane/apis
2 files changed
+4
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
| 14 | + | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
0 commit comments