Commit c26cda8
authored
Adds support for Certificate resources (#2)
Initial support for Certificate resources. Items to note:
We hardcode `ValidationMethod` to "DNS" because the "EMAIL" validation method means cert renewal is not automateable. See https://docs.aws.amazon.com/acm/latest/userguide/email-validation.html
We have some custom validation of the number of domain validation options. When requesting a public certificate with DNS validation, you can only submit a max of 5 subdomains/CNAME records for use in DNS validation, and since we hardcode DNS validation method, we need to check for this and put the Certificate into a Terminal state if there are more than 5 CNAME records listed in the DomainValidationOptions field.
Finally, we add a simple sleep of 5 seconds after successful creation since
https://docs.aws.amazon.com/acm/latest/APIReference/API_RequestCertificate.html warns us that DescribeCertificate calls will not succeed for several seconds after a RequestCertificate call has returned the CertificateArn...
Issue aws-controllers-k8s/community#482
Signed-off-by: Jay Pipes <jaypipes@gmail.com>
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.1 parent f5e3cd4 commit c26cda8
File tree
32 files changed
+3149
-15
lines changed- apis/v1alpha1
- cmd/controller
- config
- crd
- bases
- rbac
- helm
- crds
- templates
- pkg/resource/certificate
- templates/hooks/certificate
32 files changed
+3149
-15
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
| 2 | + | |
| 3 | + | |
4 | 4 | | |
5 | | - | |
6 | | - | |
| 5 | + | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments