chore(deps-dev): bump @biomejs/biome from 1.9.4 to 2.1.2 (#1410)

* chore(deps-dev): bump @biomejs/biome from 1.9.4 to 2.1.2

Bumps [@biomejs/biome](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome) from 1.9.4 to 2.1.2.
- [Release notes](https://github.com/biomejs/biome/releases)
- [Changelog](https://github.com/biomejs/biome/blob/main/packages/@biomejs/biome/CHANGELOG.md)
- [Commits](https://github.com/biomejs/biome/commits/@biomejs/biome@2.1.2/packages/@biomejs/biome)

---
updated-dependencies:
- dependency-name: "@biomejs/biome"
  dependency-version: 2.1.2
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: bump biome and fix linting errors

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kellertk <kellertk@amazon.com>
Co-authored-by: Tom Keller <1083460+kellertk@users.noreply.github.com>

Author: dependabot[bot]

__mocks__/fs.cjs

@@ -1,2 +1,2 @@
-const { fs } = require('memfs')
-module.exports = fs
+const { fs } = require('memfs');
+module.exports = fs;

biome.jsonc

@@ -4,31 +4,31 @@
     "lineWidth": 120,
     "indentWidth": 2,
     "lineEnding": "lf",
-    "enabled": true,
+    "enabled": true
   },
   "linter": {
     "enabled": true,
     "rules": {
       "performance": {
-        "noDelete": "off",
+        "noDelete": "off"
       },
       "complexity": {
-        "noExtraBooleanCast": "off",
+        "noExtraBooleanCast": "off"
       }
-    },
+    }
   },
   "javascript": {
     "formatter": {
       "trailingCommas": "all",
       "jsxQuoteStyle": "double",
       "quoteStyle": "single",
       "bracketSpacing": true,
-      "arrowParentheses": "always",
-    },
+      "arrowParentheses": "always"
+    }
   },
   "json": {
     "formatter": {
-      "trailingCommas": "all",
-    },
-  },
+      "trailingCommas": "none"
+    }
+  }
 }

package-lock.json

@@ -15,7 +15,7 @@
   },
   "devDependencies": {
     "@aws-sdk/credential-provider-env": "^3.858.0",
-    "@biomejs/biome": "1.9.4",
+    "@biomejs/biome": "2.1.3",
     "@smithy/property-provider": "^4.0.3",
     "@types/node": "^24.0.3",
     "@vercel/ncc": "^0.38.3",

package.json

@@ -142,7 +142,6 @@ export async function assumeRole(params: assumeRoleParams) {
     PolicyArns: managedSessionPolicies?.length ? managedSessionPolicies : undefined,
   };
   const keys = Object.keys(commonAssumeRoleParams) as Array<keyof typeof commonAssumeRoleParams>;
-  // biome-ignore lint/complexity/noForEach: Legacy code
   keys.forEach((k) => commonAssumeRoleParams[k] === undefined && delete commonAssumeRoleParams[k]);
 
   // Instantiate STS client

src/assumeRole.ts

@@ -178,7 +178,6 @@ export async function retryAndBackoff<T>(
     }
     // It's retryable, so sleep and retry.
     await sleep(Math.random() * (2 ** retries * base));
-    // biome-ignore lint/style/noParameterAssign: This is a loop variable
     retries += 1;
     if (retries >= maxRetries) {
       throw err;

src/helpers.ts

@@ -1,7 +1,7 @@
 import * as core from '@actions/core';
 import type { AssumeRoleCommandOutput } from '@aws-sdk/client-sts';
-import { CredentialsClient } from './CredentialsClient';
 import { assumeRole } from './assumeRole';
+import { CredentialsClient } from './CredentialsClient';
 import {
   areCredentialsValid,
   errorMessage,

src/index.ts

@@ -1,8 +1,8 @@
-import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
-import { cleanup } from '../src/cleanup';
 import * as core from '@actions/core';
-import { mockClient } from 'aws-sdk-client-mock';
 import { STSClient } from '@aws-sdk/client-sts';
+import { mockClient } from 'aws-sdk-client-mock';
+import { beforeEach, describe, expect, it, vi } from 'vitest';
+import { cleanup } from '../src/cleanup';
 import mocks from './mockinputs.test';
 
 const mockedSTSClient = mockClient(STSClient);
@@ -49,5 +49,5 @@ describe('Configure AWS Credentials cleanup', {}, () => {
     vi.spyOn(core, 'getInput').mockImplementation(mocks.getInput(mocks.NO_ENV_CREDS_INPUTS));
     cleanup();
     expect(core.exportVariable).toHaveBeenCalledTimes(0);
-  })
+  });
 });

test/cleanup.test.ts

@@ -1,7 +1,7 @@
-import { describe, it, expect, vi } from 'vitest';
-import * as helpers from '../src/helpers';
+import { beforeEach } from 'node:test';
 import * as core from '@actions/core';
-import { before, beforeEach } from 'node:test';
+import { describe, expect, it, vi } from 'vitest';
+import * as helpers from '../src/helpers';
 
 describe('Configure AWS Credentials helpers', {}, () => {
   beforeEach(() => {
@@ -27,7 +27,11 @@ describe('Configure AWS Credentials helpers', {}, () => {
     vi.spyOn(core, 'setOutput').mockImplementation(() => {});
     vi.spyOn(core, 'setSecret').mockImplementation(() => {});
     vi.spyOn(core, 'exportVariable').mockImplementation(() => {});
-    helpers.exportCredentials({ AccessKeyId: 'test', SecretAccessKey: 'test', SessionToken: 'test', Expiration: new Date(8640000000000000) }, true, true);
+    helpers.exportCredentials(
+      { AccessKeyId: 'test', SecretAccessKey: 'test', SessionToken: 'test', Expiration: new Date(8640000000000000) },
+      true,
+      true,
+    );
     expect(core.setOutput).toHaveBeenCalledTimes(4);
     expect(core.setSecret).toHaveBeenCalledTimes(3);
     expect(core.exportVariable).toHaveBeenCalledTimes(3);
@@ -46,7 +50,11 @@ describe('Configure AWS Credentials helpers', {}, () => {
     vi.spyOn(core, 'setOutput').mockImplementation(() => {});
     vi.spyOn(core, 'setSecret').mockImplementation(() => {});
     vi.spyOn(core, 'exportVariable').mockImplementation(() => {});
-    helpers.exportCredentials({ AccessKeyId: 'test', SecretAccessKey: 'test', SessionToken: 'test', Expiration: new Date(8640000000000000) }, true, false);
+    helpers.exportCredentials(
+      { AccessKeyId: 'test', SecretAccessKey: 'test', SessionToken: 'test', Expiration: new Date(8640000000000000) },
+      true,
+      false,
+    );
     helpers.unsetCredentials(false);
     helpers.exportRegion('fake-test-region', false);
     expect(core.setOutput).toHaveBeenCalledTimes(4);

test/helpers.test.ts

@@ -1,17 +1,16 @@
-import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import * as core from '@actions/core';
 import {
   AssumeRoleCommand,
   AssumeRoleWithWebIdentityCommand,
   GetCallerIdentityCommand,
   STSClient,
 } from '@aws-sdk/client-sts';
-import { fs, vol } from 'memfs';
-import * as core from '@actions/core';
-import mocks from './mockinputs.test';
 import { mockClient } from 'aws-sdk-client-mock';
-import { run } from '../src/index';
+import { fs, vol } from 'memfs';
+import { beforeEach, describe, expect, it, vi } from 'vitest';
 import { CredentialsClient } from '../src/CredentialsClient';
-import { before } from 'node:test';
+import { run } from '../src/index';
+import mocks from './mockinputs.test';
 
 const mockedSTSClient = mockClient(STSClient);
 
@@ -300,19 +299,19 @@ describe('Configure AWS Credentials', {}, () => {
       await run();
       expect(core.setFailed).toHaveBeenCalled();
     });
-    it('gets new creds if told to reuse existing but they\'re invalid', {}, async () => {
+    it("gets new creds if told to reuse existing but they're invalid", {}, async () => {
       vi.spyOn(core, 'getInput').mockImplementation(mocks.getInput(mocks.USE_EXISTING_CREDENTIALS_INPUTS));
       mockedSTSClient.on(GetCallerIdentityCommand).rejects();
       await run();
-      expect(core.notice).toHaveBeenCalledWith('No valid credentials exist. Running as normal.')
+      expect(core.notice).toHaveBeenCalledWith('No valid credentials exist. Running as normal.');
     });
-    it('doesn\'t get new creds if there are already valid ones and we said use them', {}, async () => {
+    it("doesn't get new creds if there are already valid ones and we said use them", {}, async () => {
       vi.spyOn(core, 'getInput').mockImplementation(mocks.getInput(mocks.USE_EXISTING_CREDENTIALS_INPUTS));
       mockedSTSClient.on(GetCallerIdentityCommand).resolves(mocks.outputs.GET_CALLER_IDENTITY);
       await run();
       expect(core.setFailed).not.toHaveBeenCalled();
-    })
-    it('doesn\'t export credentials as environment variables if told not to', {}, async () => {
+    });
+    it("doesn't export credentials as environment variables if told not to", {}, async () => {
       mockedSTSClient.on(AssumeRoleWithWebIdentityCommand).resolvesOnce(mocks.outputs.STS_CREDENTIALS);
       vi.spyOn(core, 'getInput').mockImplementation(mocks.getInput(mocks.NO_ENV_CREDS_INPUTS));
       vi.spyOn(core, 'getIDToken').mockResolvedValue('testoidctoken');
@@ -321,7 +320,7 @@ describe('Configure AWS Credentials', {}, () => {
       expect(core.setSecret).toHaveBeenCalledTimes(3);
       expect(core.exportVariable).toHaveBeenCalledTimes(0);
       expect(core.setFailed).not.toHaveBeenCalled();
-    })
+    });
     it('can export creds as step outputs without exporting as env variables', {}, async () => {
       mockedSTSClient.on(AssumeRoleWithWebIdentityCommand).resolvesOnce(mocks.outputs.STS_CREDENTIALS);
       vi.spyOn(core, 'getInput').mockImplementation(mocks.getInput(mocks.STEP_BUT_NO_ENV_INPUTS));
@@ -332,6 +331,6 @@ describe('Configure AWS Credentials', {}, () => {
       expect(core.exportVariable).toHaveBeenCalledTimes(0);
       expect(core.setOutput).toHaveBeenCalledTimes(4);
       expect(core.setFailed).not.toHaveBeenCalled();
-    })
+    });
   });
 });