RHAIENG-308, opendatahub-io#2242: tests(make): handle rstudio in a rhds-compatible manner (opendatahub-io#2277)

Author: jiridanek

tests/manifests.py

@@ -185,7 +185,10 @@ def get_source_of_truth_filepath(
                 filename = f"jupyter-{notebook_id}-{file_suffix}"
 
         elif RSTUDIO_NOTEBOOK_ID in notebook_id:
-            filename = f"rstudio-gpu-{file_suffix}"
+            imagestream_filename = f"rstudio-gpu-{file_suffix}"
+            buildconfig_filename = "cuda-rstudio-buildconfig.yaml"
+            _ = imagestream_filename
+            filename = buildconfig_filename
 
     if not filename:
         raise ValueError(

tests/test_main.py

@@ -378,7 +378,12 @@ def load_manifests_file_for(directory: pathlib.Path) -> Manifest:
             f"Computed filepath '{manifest_file}' does not exist."
         )
 
-    imagestream = yaml.safe_load(manifest_file.read_text())
+    # BEWARE: rhds rstudio has imagestream bundled in the buildconfig yaml
+    if "buildconfig" in manifest_file.name:
+        # imagestream is the first document in the file
+        imagestream = next(yaml.safe_load_all(manifest_file.read_text()))
+    else:
+        imagestream = yaml.safe_load(manifest_file.read_text())
     recommended_tags = [
         tag
         for tag in imagestream["spec"]["tags"]