Merge pull request #71 from atc-net/feature/Move-some-code-to-nuget-packages

Feature/move some code to nuget packages

Author: davidkallesen

Directory.Build.props

@@ -43,7 +43,7 @@
   <ItemGroup Label="Code Analyzers">
     <PackageReference Include="AsyncFixer" Version="1.5.1" PrivateAssets="All" />
     <PackageReference Include="Asyncify" Version="0.9.7" PrivateAssets="All" />
-    <PackageReference Include="Meziantou.Analyzer" Version="1.0.689" PrivateAssets="All" />
+    <PackageReference Include="Meziantou.Analyzer" Version="1.0.694" PrivateAssets="All" />
     <PackageReference Include="SecurityCodeScan.VS2019" Version="5.6.0" PrivateAssets="All" />
     <PackageReference Include="StyleCop.Analyzers" Version="1.1.118" PrivateAssets="All" />
     <PackageReference Include="SonarAnalyzer.CSharp" Version="8.35.0.42613" PrivateAssets="All" />

README.md

@@ -169,15 +169,15 @@ Running the command above produces the following output
  |_| \_\  \__,_| |_|  \___| |___/    \__,_| | .__/   \__,_|  \__,_|  \__|  \___| |_|
                                             |_|
 🐭 Working on EditorConfig files
-🟢   /.editorconfig files merged
-🟢   sample/.editorconfig created
-🟢   src/.editorconfig created
-🟢   test/.editorconfig created
+🟢   root: .editorconfig files merged
+🟢   sample: .editorconfig created
+🟢   src: .editorconfig created
+🟢   test: .editorconfig created
 🔨 Working on Directory.Build.props files
-🟢   /Directory.Build.props created
-🟢   sample/Directory.Build.props created
-🟢   src/Directory.Build.props created
-🟢   test/Directory.Build.props created
+🟢   root: Directory.Build.props created
+🟢   sample: Directory.Build.props created
+🟢   src: Directory.Build.props created
+🟢   test: Directory.Build.props created
 ✅ Done
 ```
 

src/Atc.CodingRules.AnalyzerProviders/Atc.CodingRules.AnalyzerProviders.csproj

@@ -9,8 +9,8 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Atc" Version="1.1.385" />
-    <PackageReference Include="HtmlAgilityPack" Version="1.11.40" />
+    <PackageReference Include="Atc" Version="2.0.55" />
+    <PackageReference Include="HtmlAgilityPack" Version="1.11.42" />
   </ItemGroup>
 
   <ItemGroup>

src/Atc.CodingRules.AnalyzerProviders/Providers/AnalyzerProviderBase.cs

@@ -2,8 +2,7 @@ namespace Atc.CodingRules.AnalyzerProviders.Providers;
 
 public abstract class AnalyzerProviderBase : IAnalyzerProvider
 {
-    [SuppressMessage("Minor Code Smell", "S1075:URIs should not be hardcoded", Justification = "OK.")]
-    private const string GitRawAtcAnalyzerProviderBaseRulesBasePath = "https://raw.githubusercontent.com/atc-net/atc-coding-rules-updater/main/AnalyzerProviderBaseRules/";
+    private const string GitRawAtcAnalyzerProviderBaseRulesBasePath = Constants.GitRawContentUrl + "/atc-net/atc-coding-rules-updater/main/AnalyzerProviderBaseRules/";
     private readonly ILogger logger;
     private readonly bool logWithAnsiConsoleMarkup;
 
@@ -133,7 +132,12 @@ protected static Task WriteToTempFolder(
     {
         ArgumentNullException.ThrowIfNull(data);
 
-        var rawGitData = HttpClientHelper.GetAsString(logger, GitRawAtcAnalyzerProviderBaseRulesBasePath + data.Name + ".json");
+        var url = GitRawAtcAnalyzerProviderBaseRulesBasePath + data.Name + ".json";
+        var displayName = url.Replace(Constants.GitRawContentUrl, Constants.GitHubPrefix, StringComparison.Ordinal);
+        var rawGitData = HttpClientHelper.GetAsString(
+            logger,
+            url,
+            displayName);
         return Task.FromResult(string.IsNullOrEmpty(rawGitData)
             ? null
             : JsonSerializer.Deserialize<AnalyzerProviderBaseRuleData>(rawGitData, AnalyzerProviderSerialization.JsonOptions)!);

src/Atc.CodingRules.Updater.CLI/Atc.CodingRules.Updater.CLI.csproj

@@ -12,10 +12,10 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Atc" Version="1.1.385" />
-    <PackageReference Include="Atc.Console.Spectre" Version="1.1.385" />
-    <PackageReference Include="EPPlus" Version="5.8.5" />
-    <PackageReference Include="Microsoft.Extensions.Hosting" Version="6.0.0" />
+    <PackageReference Include="Atc" Version="2.0.55" />
+    <PackageReference Include="Atc.Console.Spectre" Version="2.0.55" />
+    <PackageReference Include="EPPlus" Version="5.8.6" />
+    <PackageReference Include="Microsoft.Extensions.Hosting" Version="6.0.1" />
   </ItemGroup>
 
   <ItemGroup>

src/Atc.CodingRules.Updater.CLI/Commands/AnalyzerProvidersCacheCleanupCommand.cs

@@ -21,7 +21,7 @@ public override int Execute(CommandContext context)
             return ConsoleExitStatusCodes.Failure;
         }
 
-        logger.LogInformation($"{EmojisConstants.Done} Done");
+        logger.LogInformation($"{EmojisConstants.Success} Done");
         return ConsoleExitStatusCodes.Success;
     }
 }

src/Atc.CodingRules.Updater.CLI/Commands/AnalyzerProvidersCollectCommand.cs

@@ -37,7 +37,7 @@ await AnalyzerProviderBaseRulesHelper.GetAnalyzerProviderBaseRules(
             return ConsoleExitStatusCodes.Failure;
         }
 
-        logger.LogInformation($"{EmojisConstants.Done} Done");
+        logger.LogInformation($"{EmojisConstants.Success} Done");
         return ConsoleExitStatusCodes.Success;
     }
 

src/Atc.CodingRules.Updater.CLI/Commands/ArgumentCommandConstants.cs

@@ -0,0 +1,20 @@
+namespace Atc.CodingRules.Updater.CLI.Commands;
+
+internal static class ArgumentCommandConstants
+{
+    public const string ShortProjectPath = "-p";
+    public const string LongProjectPath = "--projectPath";
+    public const string ShortOptionsPath = "-o";
+    public const string LongOptionsTarget = "--optionsPath";
+    public const string ShortProjectTarget = "-t";
+    public const string LongProjectTarget = "--projectTarget";
+    public const string LongUseLatestMinorNugetVersion = "--useLatestMinorNugetVersion";
+    public const string ShortUseTemporarySuppressions = "-s";
+    public const string LongUseTemporarySuppressions = "--useTemporarySuppressions";
+    public const string LongTemporarySuppressionPath = "--temporarySuppressionPath";
+    public const string LongTemporarySuppressionAsExcel = "--temporarySuppressionAsExcel";
+    public const string LongBuildFile = "--buildFile";
+    public const string LongFetchMode = "--fetchMode";
+    public const string LongOrganizationName = " --organizationName";
+    public const string LongRepositoryName = " --repositoryName";
+}

src/Atc.CodingRules.Updater.CLI/Commands/CommandConstants.cs

@@ -2,7 +2,7 @@
 
 namespace Atc.CodingRules.Updater.CLI.Commands.DescriptionAttributes;
 
-[AttributeUsage(AttributeTargets.All)]
+[AttributeUsage(AttributeTargets.Property | AttributeTargets.Field | AttributeTargets.Enum | AttributeTargets.Interface | AttributeTargets.Delegate)]
 public sealed class ProviderCollectingModeDescriptionAttribute : DescriptionAttribute
 {
     public override string Description