🚧 progress(test): Enable power-assert when running tests.

Author: make-github-pseudonymous-again

package.json

@@ -58,7 +58,7 @@
     "prepublishOnly": "pinst --disable",
     "release": "np --message ':hatching_chick: release: Bumping to v%s.'",
     "test": "npm run test:src",
-    "test-cmd": "ava",
+    "test-cmd": "NODE_LOADER_CONFIG=test/loader/config.js ava",
     "test:cjs": "IMPORT_MAP_PATH=test/import-maps/dist/index.json npm run test-cmd",
     "test:dist": "npm run test:modern && npm run test:module && npm run test:cjs",
     "test:modern": "IMPORT_MAP_PATH=test/import-maps/dist/index.modern.json npm run test-cmd",
@@ -72,6 +72,8 @@
     "@babel/register": "7.16.0",
     "@commitlint/cli": "15.0.0",
     "@js-library/commitlint-config": "0.0.4",
+    "@node-loader/babel": "^2.0.0",
+    "@node-loader/core": "^2.0.0",
     "@node-loader/import-maps": "^1.0.3",
     "ava": "^4.0.0-rc.1",
     "babel-plugin-transform-remove-console": "6.9.4",
@@ -101,20 +103,12 @@
       "regenerator-runtime/runtime"
     ],
     "nodeArguments": [
-      "--experimental-loader=@node-loader/import-maps"
+      "--experimental-loader=@node-loader/core"
     ],
     "timeout": "1m"
   },
   "babel": {
     "sourceMaps": true,
-    "presets": [
-      [
-        "@babel/preset-env",
-        {
-          "targets": "current node"
-        }
-      ]
-    ],
     "plugins": [
       [
         "transform-remove-console",
@@ -129,6 +123,7 @@
     ],
     "env": {
       "debug": {
+        "sourceMaps": "both",
         "presets": [
           "babel-preset-power-assert"
         ],
@@ -147,6 +142,7 @@
         ]
       },
       "test": {
+        "sourceMaps": "both",
         "presets": [
           "babel-preset-power-assert"
         ]
@@ -206,6 +202,7 @@
       "unicorn"
     ],
     "rules": {
+      "unicorn/prefer-node-protocol": "off",
       "import/no-anonymous-default-export": "off",
       "unicorn/filename-case": [
         "error",

src/split.js

@@ -1,4 +1,4 @@
-import assert from 'node:assert';
+import assert from 'assert';
 import fromAsyncIterable from './fromAsyncIterable.js';
 import exhaust from './exhaust.js';
 

test/loader/babel.js

@@ -0,0 +1,116 @@
+/**
+ * Based on source of @node-loader/babel
+ *
+ * Source: https://github.com/node-loader/node-loader-babel
+ *
+ * with the following license:
+ *
+ * MIT License
+ *
+ * Copyright (c) 2020 node-loaders
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+import process from 'process';
+import path from 'path';
+import urlModule from 'url';
+import babel from '@babel/core';
+
+const {loadOptionsAsync, transformAsync} = babel;
+
+const isBabelConfigFile = (filename) => {
+	const basename = path.basename(filename);
+	return (
+		basename === '.babelrc.js' ||
+		basename === '.babelrc.mjs' ||
+		basename === 'babel.config.js' ||
+		basename === 'babel.config.mjs' ||
+		basename === '.babelrc' ||
+		basename === '.babelrc.cjs' ||
+		basename === 'babel.config.cjs'
+	);
+};
+
+const getFormatWithCertitude = (filename) => {
+	return /\.cjs$/.test(filename)
+		? 'commonjs'
+		: /\.mjs$/.test(filename)
+		? 'module'
+		: undefined;
+};
+
+const getFormat = (filename) => {
+	const packageType = 'module'; // TODO query package.json
+	const defaultFormat = 'json'; // TODO is this correct as default?
+
+	return (
+		getFormatWithCertitude(filename) ??
+		(/\.js$/.test(filename) ? packageType : defaultFormat)
+	);
+};
+
+const getSourceType = (filename) => {
+	// TODO replace with getFormat once getFormat queries package.json
+	const format = getFormatWithCertitude(filename);
+
+	switch (format) {
+		case 'module':
+			return 'module';
+		case 'commonjs':
+			return 'script';
+		default:
+			return 'unambiguous';
+	}
+};
+
+const skip = (url) => {
+	return /node_modules/.test(url) || /node:/.test(url);
+};
+
+export const load = async (url, context, defaultLoad) => {
+	if (skip(url)) return defaultLoad(url, context, defaultLoad);
+
+	const {source} = await defaultLoad(url, context, defaultLoad);
+
+	const filename = urlModule.fileURLToPath(url);
+	// Babel config files can themselves be ES modules,
+	// but we cannot transform those since doing so would cause an infinite loop.
+	if (isBabelConfigFile(filename)) {
+		return {
+			source,
+			format: getFormat(filename),
+		};
+	}
+
+	const options = await loadOptionsAsync({
+		sourceType: getSourceType(filename),
+		root: process.cwd(),
+		rootMode: 'root',
+		filename,
+		configFile: true,
+	});
+	const transformed = await transformAsync(source, options);
+
+	return {
+		source: transformed.code,
+		// TODO: look at babel config to see whether it will output ESM/CJS or other formats
+		format: getFormat(filename),
+	};
+};

test/loader/config.js

@@ -0,0 +1,7 @@
+import * as importMapLoader from '@node-loader/import-maps';
+// Import * as babelLoader from "@node-loader/babel";
+import * as babelLoader from './babel.js';
+
+export default {
+	loaders: [importMapLoader, babelLoader],
+};

yarn.lock

@@ -1174,6 +1174,16 @@
   resolved "https://registry.yarnpkg.com/@js-library/commitlint-config/-/commitlint-config-0.0.4.tgz#5243a58b0d4ad36999d4b944c7770c50658c68f5"
   integrity sha512-l6un9f0HmIJZswqGe5H/HGBkENpqBQv1b36bdLZLXhZEZBTlm2Chbv3J1hJ2kNG8ogh+EFV5nUYQnL3MefLSDQ==
 
+"@node-loader/babel@^2.0.0":
+  version "2.0.0"
+  resolved "https://registry.yarnpkg.com/@node-loader/babel/-/babel-2.0.0.tgz#59d153d0c27737faae22da9368704a46ea93961a"
+  integrity sha512-aEnLPbryL7NCAxMcj8NmRzGID161/2H0hTlhsjtGLuxxuw9w2900CFUmfZEIrw0XkoKOQhHwY4swF/o2WCR3sQ==
+
+"@node-loader/core@^2.0.0":
+  version "2.0.0"
+  resolved "https://registry.yarnpkg.com/@node-loader/core/-/core-2.0.0.tgz#7f5a3a91fe137c8e71c0813f3bbaa0ee136a1308"
+  integrity sha512-7wV4qj2/tROXGgoYWmNvObUXbXqSv1yUD31K79Jt1q7NDuqrLz4WjjW+wVoCNgVcl8+YSj9BvLX8KsB/SrSzuw==
+
 "@node-loader/import-maps@^1.0.3":
   version "1.0.3"
   resolved "https://registry.yarnpkg.com/@node-loader/import-maps/-/import-maps-1.0.3.tgz#4dff536d5dd4d9ff3510e1d2e0ddaf86630d4299"
@@ -1396,7 +1406,7 @@
   dependencies:
     "@types/node" "*"
 
-"@typescript-eslint/eslint-plugin@*":
+"@typescript-eslint/eslint-plugin@^5.4.0":
   version "5.6.0"
   resolved "https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin/-/eslint-plugin-5.6.0.tgz#efd8668b3d6627c46ce722c2afe813928fe120a0"
   integrity sha512-MIbeMy5qfLqtgs1hWd088k1hOuRsN9JrHUPwVVKCD99EOUqScd7SrwoZl4Gso05EAP9w1kvLWUVGJOVpRPkDPA==
@@ -1422,7 +1432,7 @@
     eslint-scope "^5.1.1"
     eslint-utils "^3.0.0"
 
-"@typescript-eslint/parser@*":
+"@typescript-eslint/parser@^5.4.0":
   version "5.6.0"
   resolved "https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-5.6.0.tgz#11677324659641400d653253c03dcfbed468d199"
   integrity sha512-YVK49NgdUPQ8SpCZaOpiq1kLkYRPMv9U5gcMrywzI8brtwZjr/tG3sZpuHyODt76W/A0SufNjYt9ZOgrC4tLIQ==
@@ -3483,7 +3493,7 @@ eslint-config-prettier@^8.3.0:
   resolved "https://registry.yarnpkg.com/eslint-config-prettier/-/eslint-config-prettier-8.3.0.tgz#f7471b20b6fe8a9a9254cc684454202886a2dd7a"
   integrity sha512-BgZuLUSeKzvlL/VUjx/Yb787VQ26RU3gGjA3iiFvdsp/2bMfVIWUVP7tjxtjS0e+HP409cPlPvNkQloz8C91ew==
 
-eslint-config-xo-typescript@*:
+eslint-config-xo-typescript@^0.47.1:
   version "0.47.1"
   resolved "https://registry.yarnpkg.com/eslint-config-xo-typescript/-/eslint-config-xo-typescript-0.47.1.tgz#87b5865d8a3428fa26cc8dc3146ef4f712dfed46"
   integrity sha512-BkbzIltZCWp8QLekKJKG8zJ/ZGezD8Z9FaJ+hJ5PrAVUGkIPmxXLLEHCKS3ax7oOqZLYQiG+jyKfQDIEdTQgbg==