Upgrade actions/upload-artifact and actions/download-artifact to v4

The workflow previously uploaded multiple artifacts under the same
'name'. This is no more allowed on v4, so we have to upload each
artifact under a unique name. When downloading we can merge multiple
artifacts using the 'pattern' matching and the `merge-multiple: true`
option.

Author: cmaglie

workflow-templates/publish-go-nightly-task.yml

@@ -54,10 +54,10 @@ jobs:
         run: task dist:${{ matrix.os }}
 
       - name: Upload artifacts
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           if-no-files-found: error
-          name: ${{ env.ARTIFACT_NAME }}
+          name: ${{ env.ARTIFACT_NAME }}-${{ matrix.os }}
           path: ${{ env.DIST_DIR }}
 
   notarize-macos:
@@ -88,9 +88,10 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Download artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
-          name: ${{ env.ARTIFACT_NAME }}
+          pattern: ${{ env.ARTIFACT_NAME }}-*
+          merge-multiple: true
           path: ${{ env.DIST_DIR }}
 
       - name: Import Code-Signing Certificates
@@ -165,10 +166,10 @@ jobs:
           echo "PACKAGE_FILENAME=$PACKAGE_FILENAME" >> $GITHUB_ENV
 
       - name: Upload artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           if-no-files-found: error
-          name: ${{ env.ARTIFACT_NAME }}
+          name: ${{ env.ARTIFACT_NAME }}-notarized-${{ matrix.artifact.name }}
           path: ${{ env.DIST_DIR }}/${{ env.PACKAGE_FILENAME }}
 
   publish-nightly:
@@ -180,9 +181,10 @@ jobs:
 
     steps:
       - name: Download artifact
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
-          name: ${{ env.ARTIFACT_NAME }}
+          pattern: ${{ env.ARTIFACT_NAME }}-*
+          merge-multiple: true
           path: ${{ env.DIST_DIR }}
 
       - name: Create checksum file