Restrict HTTP request error handling to appropriate exception

The "arduino/report-size-deltas" action relies on the GitHub REST API. It makes HTTP requests to various API endpoints
during each workflow run.

It is expected that these requests might occasionally produce an exception due to transient network outages. For this
reason, the action has special handling of exceptions. Previously, that exception handling code was configured to be
triggered on any exception, even though it is specific to HTTP request errors. It is more appropriate to target it only
to the specific urllib.error.HTTPError exception that results from an HTTP request error, leaving any other types of
unexpected exceptions unhandled.

Author: per1234

reportsizedeltas/reportsizedeltas.py

@@ -637,7 +637,7 @@ def raw_http_request(self, url: str, data: bytes | None = None):
                 if url.startswith("https://api.github.com") and not url.startswith("https://api.github.com/rate_limit"):
                     self.handle_rate_limiting()
                 return urllib.request.urlopen(url=request)
-            except Exception as exception:
+            except urllib.error.HTTPError as exception:
                 if not determine_urlopen_retry(exception=exception):
                     raise exception
 
@@ -664,7 +664,7 @@ def handle_rate_limiting(self) -> None:
             sys.exit(0)
 
 
-def determine_urlopen_retry(exception) -> bool:
+def determine_urlopen_retry(exception: urllib.error.HTTPError) -> bool:
     """Determine whether the exception warrants another attempt at opening the URL.
     If so, delay then return True. Otherwise, return False.
 

reportsizedeltas/tests/test_reportsizedeltas.py

@@ -901,9 +901,11 @@ def test_raw_http_request(mocker):
     urllib.request.urlopen.assert_called_once_with(url=request)
 
     # urllib.request.urlopen() has non-recoverable exception
-    urllib.request.urlopen.side_effect = Exception()
+    urllib.request.urlopen.side_effect = urllib.error.HTTPError(
+        url="http://example.com", code=404, msg="", hdrs=None, fp=None
+    )
     mocker.patch("reportsizedeltas.determine_urlopen_retry", autospec=True, return_value=False)
-    with pytest.raises(expected_exception=Exception):
+    with pytest.raises(expected_exception=urllib.error.HTTPError):
         report_size_deltas.raw_http_request(url=url, data=data)
 
     # urllib.request.urlopen() has potentially recoverable exceptions, but exceeds retry count