Inherit configuration from parent folders

It starts from the root and for every folder until $PWD it
parses the yaml. Files closer to $PWD take precedence

Author: matteosuppo

configs/navigate.go

@@ -1,14 +1,19 @@
 package configs
 
 import (
-	"fmt"
+	"path/filepath"
+	"strings"
 
 	paths "github.com/arduino/go-paths-helper"
 	homedir "github.com/mitchellh/go-homedir"
 )
 
 func Navigate(root, pwd string) Configuration {
-	fmt.Println("Navigate", root, pwd)
+	relativePath, err := filepath.Rel(root, pwd)
+	if err != nil {
+		panic(err)
+	}
+
 	home, err := homedir.Dir()
 	if err != nil {
 		panic(err) // Should never happen
@@ -20,8 +25,14 @@ func Navigate(root, pwd string) Configuration {
 		DataDir:       paths.New(home, ".arduino15"),
 	}
 
-	// Search for arduino-cli.yaml in current folder
-	_ = config.LoadFromYAML(paths.New(pwd, "arduino-cli.yaml"))
+	// From the root to the current folder, search for arduino-cli.yaml files
+	parts := strings.Split(relativePath, string(filepath.Separator))
+	for i := range parts {
+		path := paths.New(root)
+		path = path.Join(parts[:i+1]...)
+		path = path.Join("arduino-cli.yaml")
+		_ = config.LoadFromYAML(path)
+	}
 
 	return config
 }

configs/navigate_test.go

@@ -15,6 +15,7 @@ func TestNavigate(t *testing.T) {
 	tests := []string{
 		"noconfig",
 		"local",
+		"inheritance",
 	}
 	for _, tt := range tests {
 		t.Run(tt, func(t *testing.T) {

configs/testdata/navigate/inheritance/first/arduino-cli.yaml

@@ -0,0 +1,5 @@
+sketchbook_path: /tmp
+board_manager:
+  additional_urls:
+    - https://downloads.arduino.cc/package_index_mraa.json
+    

configs/testdata/navigate/inheritance/first/second/.gitkeep

@@ -0,0 +1,4 @@
+board_manager:
+  additional_urls:
+    - https://downloads.arduino.cc/package_index_mraa.json
+    

configs/testdata/navigate/inheritance/first/second/arduino-cli.yaml

@@ -0,0 +1,6 @@
+proxy_type: ""
+sketchbook_path: /tmp
+arduino_data: $HOME/.arduino15
+board_manager:
+  additional_urls:
+  - https://downloads.arduino.cc/package_index_mraa.json

configs/testdata/navigate/inheritance/golden.yaml

@@ -112,7 +112,7 @@ func (config *Configuration) SerializeToYAML() ([]byte, error) {
 	if len(config.BoardManagerAdditionalUrls) > 0 {
 		c.BoardsManager = &yamlBoardsManagerConfig{AdditionalURLS: []string{}}
 		for _, URL := range config.BoardManagerAdditionalUrls {
-			c.BoardsManager.AdditionalURLS = append(c.BoardsManager.AdditionalURLS, URL.String())
+			c.BoardsManager.AdditionalURLS = appendIfMissing(c.BoardsManager.AdditionalURLS, URL.String())
 		}
 	}
 	return yaml.Marshal(c)
@@ -130,3 +130,12 @@ func (config *Configuration) SaveToYAML(path string) error {
 	}
 	return nil
 }
+
+func appendIfMissing(slice []string, i string) []string {
+	for _, ele := range slice {
+		if ele == i {
+			return slice
+		}
+	}
+	return append(slice, i)
+}