Change the directory of the configuration files

If you install the arduino cli, the default directory
of the configuration file is the location of the executable
This is not an ideal configuration for linux or windows

With this commit the configuration file is searched in the
default configuration folder for each system

Author: matteosuppo

Gopkg.lock

@@ -295,7 +295,7 @@ Flags:
   -h, --help   help for core
 
 Global Flags:
-      --config-file string   The custom config file (if not specified ./.cli-config.yml will be used). (default "/home/megabug/Workspace/go/src/github.com/arduino/arduino-cli/.cli-config.yml")
+      --config-file string   The custom config file (if not specified the default one will be used). (example  "/home/megabug/.config/arduino/arduino-cli/.cli-config.yml")
       --debug                Enables debug output (super verbose, used to debug the CLI).
       --format string        The output format, can be [text|json]. (default "text")
 

README.md

@@ -65,7 +65,14 @@ func runInitCommand(cmd *cobra.Command, args []string) {
 	if filepath == "" {
 		filepath = commands.Config.ConfigFile.String()
 	}
-	err := commands.Config.SaveToYAML(filepath)
+
+	err := os.MkdirAll(commands.Config.ConfigFile.Parent().String(), 0766)
+	if err != nil {
+		formatter.PrintError(err, "Cannot create config file.")
+		os.Exit(commands.ErrGeneric)
+	}
+
+	err = commands.Config.SaveToYAML(filepath)
 	if err != nil {
 		formatter.PrintError(err, "Cannot create config file.")
 		os.Exit(commands.ErrGeneric)

commands/config/init.go

@@ -56,7 +56,7 @@ func Init() *cobra.Command {
 	}
 	command.PersistentFlags().BoolVar(&commands.GlobalFlags.Debug, "debug", false, "Enables debug output (super verbose, used to debug the CLI).")
 	command.PersistentFlags().StringVar(&commands.GlobalFlags.Format, "format", "text", "The output format, can be [text|json].")
-	command.PersistentFlags().StringVar(&yamlConfigFile, "config-file", "", "The custom config file (if not specified ./.cli-config.yml will be used).")
+	command.PersistentFlags().StringVar(&yamlConfigFile, "config-file", "", "The custom config file (if not specified the default will be used).")
 	command.AddCommand(board.InitCommand())
 	command.AddCommand(compile.InitCommand())
 	command.AddCommand(config.InitCommand())

commands/root/root.go

@@ -19,23 +19,31 @@ package configs
 
 import (
 	"fmt"
-	"os"
 	"os/user"
 	"runtime"
 
 	"github.com/arduino/go-paths-helper"
-
 	"github.com/arduino/go-win32-utils"
+	"github.com/shibukawa/configdir"
 )
 
-// getDefaultConfigFilePath returns the default path for .cli-config.yml,
-// this is the directory where the arduino-cli executable resides.
+// getDefaultConfigFilePath returns the default path for .cli-config.yml. It searches the following directories for an existing .cli-config.yml file:
+// - User level configuration folder(e.g. $HOME/.config/<vendor-name>/<application-name>/setting.json in Linux)
+// - System level configuration folder(e.g. /etc/xdg/<vendor-name>/<application-name>/setting.json in Linux)
+// If it doesn't find one, it defaults to the user level configuration folder
 func getDefaultConfigFilePath() *paths.Path {
-	executablePath, err := os.Executable()
-	if err != nil {
-		executablePath = "."
+	configDirs := configdir.New("arduino", "arduino-cli")
+
+	// Search for a suitable configuration file
+	path := configDirs.QueryFolderContainsFile(".cli-config.yml")
+	if path != nil {
+		return paths.New(path.Path, ".cli-config.yml")
 	}
-	return paths.New(executablePath).Parent().Join(".cli-config.yml")
+	// Default to the global configuration
+	locals := configDirs.QueryFolders(configdir.Global)
+	return paths.New(locals[0].Path, ".cli-config.yml")
+
+	return nil
 }
 
 func getDefaultArduinoDataDir() (*paths.Path, error) {