fix: decoder parse_packet not working on buffers not containing exact packets. examples: decoder used on mixed incoming packets and pop_packet test

Author: eigen-value

examples/decoder_example/decoder_example.ino

@@ -70,7 +70,7 @@ void loop() {
     }
 
     if (decoder2.packet_incoming()){
-        Serial.print("packet ready. type: ");
+        Serial.print("packet incoming. type: ");
         Serial.println(decoder2.packet_type());
     }
 
@@ -94,7 +94,71 @@ void loop() {
     }
 
     if (decoder3.packet_incoming()){
-        Serial.print("packet ready. type: ");
+        Serial.print("packet incoming. type: ");
         Serial.println(decoder3.packet_type());
     }
+
+    // MIXED INCOMING RESPONSE AND REQUEST
+    blink_before();
+    packer.clear();
+    packer.serialize(resp_sz, 1, 1, nil, ret_sz, 3.0, 2);
+    packer.serialize(req_sz, 0, 1, "method", par_sz, 1.0, 2.0);
+
+    DummyTransport dummy_transport4(packer.data(), packer.size());
+    RpcDecoder<> decoder4(dummy_transport4);
+
+    while (!decoder4.packet_incoming()){
+        decoder4.print_buffer();
+        Serial.println("Packet not ready");
+        decoder4.advance();
+        decoder4.parse_packet();
+        decoder4.print_buffer();
+        delay(100);
+    }
+
+    if (decoder4.packet_incoming()){
+        Serial.print("packet ready. type: ");
+        Serial.println(decoder4.packet_type());
+
+        // as client knows the expected response types/error
+        MsgPack::arr_size_t r_resp_sz(4);
+        MsgPack::object::nil_t nil;
+        int r_type;
+        int r_msg_id;
+        MsgPack::arr_size_t r_ret_sz(2);
+        float r_float;
+        int r_int;
+
+        Serial.print("Total Decoder buf size: ");
+        Serial.println(decoder4.size());
+        for (size_t i=1; i<decoder4.size(); i++){
+
+            if (decoder4.get_next_packet(unpacker, i)){
+
+                if (unpacker.deserialize(r_resp_sz, r_type, r_msg_id)){
+                    // consistency checks
+                    if (unpacker.unpackable(nil)) { // No error case
+                        if (unpacker.deserialize(nil, r_ret_sz, r_float, r_int)){
+                            // do more checks
+                            // fill the response
+                            Serial.print("Full packet decoded size: ");
+                            Serial.println(i);
+                            decoder4.pop_packet(i);
+                            Serial.print("1st Packet popped. Decoder buf size: ");
+                            Serial.println(decoder4.size());
+                            decoder4.print_buffer();
+                            break;  //exit the loop
+                        }
+                    } else {
+                        // unpack the error
+                    }
+                    
+                }
+
+            }
+
+        }
+
+    }
+
 }

src/decoder.h

@@ -49,7 +49,7 @@ class RpcDecoder {
 
         static MsgPack::Unpacker unpacker;
         unpacker.clear();
-        unpacker.feed(_raw_buffer, _bytes_stored);
+        unpacker.feed(_raw_buffer, 2);
 
         MsgPack::arr_size_t elem_size;
         int type;
@@ -94,10 +94,12 @@ class RpcDecoder {
 
         _bytes_stored = remaining_bytes;
         _packet_type = NO_MSG;
-        
+
         return size;
     }
 
+    inline size_t size() const {return _bytes_stored;}
+
 #ifdef DEBUG
 void print_buffer(){